-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISSUE-125 Use wikidata to provide skos:definition to owl:Class'es #205
Conversation
There appear to be some files which are failing to write... I am investigating those right now. Also, I noticed that a few other files are failing due to host connection timeout issues... this may have to do with OWLAPI or the host or the process... I am not sure. |
Carried over from #203 from @dr-shorthair
I'll go ahead and fix that. Good catch. |
@dr-shorthair right now the annotation looks as follows
I'll go ahead and change these to the following
|
Yes, but realmCryo was last edited 2 months ago... Protege 5.5 doesn't throw an error, but the definition shows as blank brackets in the editor. Would the zulu time encoding from the Cryo group cause a clash? That's an odd error. |
Looking at the spreadsheet (many thanks @lewismc) it looks like abbreviations are matching to genetic elements. For example, sic, which is an equivalent class to Standard Industrial Classification (and, IMHO, should probably be a It looks like any definition starting with "genetic element in the species..." can probably be disregarded. |
@brandonnodnarb thanks for taking a look. Regarding abbreviations yes I am +1 for adding clarifying axioms as you suggest. This is a bit difficult ti implement automatically though... I don't know how I would do that.
I can implement this check pretty easily. I'll go ahead and do that. Essentially, it just means that these definitions will be dropped. |
I got a bunch of reports where
TB might be finding some stuff in imports, but diagnostics a bit lacking. |
I think this is a bug and should be addressed in a separate pull request. Are you able to submit that one?
OK, I've not experienced this one! |
Likewise--it also only displayed blank brackets when I tried. |
Apologies, this ^ was snark -- I have mentioned this before but haven't had time to address it. (I need a sarcasm font.) I think I can write a simple filter for to extract the subsets. Anwyay. Assuming #207 fixes the time stamp issue(s), I think this is good to go. There are definitely some definitions that don't seem correct, but they aren't obviously wrong --- aside from the "genetic element" defs. Assuming nothing else breaks, I think it's a good start. :) |
incorrect mapping of geologic time intervals (from the csv dump) sweet:stateTime/Age | age | http://www.wikidata.org/entity/Q185836 | "period of life of a human or organism"@en | sweet:stateTime/Epoch | epoch | http://www.wikidata.org/entity/P6259 | "epoch of an astronomical object coordinate"@en sweet:stateTime/Period | period | http://www.wikidata.org/entity/Q101843 | "row in the periodic table of elements"@en |
lots of other incorrect mappings, particularly for commonly used words, some examples:
I spent about 45 minutes scanning through the csv file , and found 138 definitions that are obviously wrong or need review; I looked at maybe a third of the rows. The really technical terms for the most part got reasonable matches. The marked up spreadsheet is available, problem defs are highlighted in yellow. |
@brandonnodnarb no problems ;) Great @smrgeoinfo some comments from you
... I will update these 3 manually in the next iteration.
I'll go ahead and manually remove these incorrect annotations. We can address them in future work. |
This pull request supersedes #203
@graybeal regarding the definitions. I simply removed the
skos:definition
's for those ones.There was only one entry which required a
skos:historyNote
this is as followsFinally, @graybeal @brandonnodnarb @rrovetto see the requested generated CSV file.