-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Geofeature defs #187
Open
nicholascar
wants to merge
9
commits into
ESIPFed:master
Choose a base branch
from
nicholascar:geofeature-defs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Geofeature defs #187
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
b33233c
Orogen, OrogenicCollage
4b15851
minor
48d1606
Craton, Supercraton, hasPart
8e193c5
Basin -> SedimentaryBasin, Subbasin, Superbasin, Trough
fe6ed5d
subclasses of GeologicFeature, other class tidy-ups
26b17a4
update Geopark source
1a1838f
absorbing PR #186 for GeologicFeature
58ef0bb
Nick & John added as contributors
1a739ca
moving core subclasses to core
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like InnerCore and OuterCore are subclasses of GeosphereLayer, with a partOf Relation to Core, not a subclass relation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not one of our mistakes- we haven't touched properties like this.
I actually do have another PR waiting in the wings for a tidy-up of the Solid Earth, Hydrosphere & Atmosphere and their layers (all using isPartOf relations) but I will wait for this PR to get through before lodging that one.