Create driver data structure for SP mode #2952
Conversation
|
Testing Removed expected fails... 0206-092821de_gnu: 65 tests 0206-092821de_int: 167 tests 0206-092821de_nvh Does anyone (@samsrabin?) know why |
Check the baseline and see if it died as well and didn't get put into expected fails. We've been having problems with the nvhpc compiler, so personally I'm not too inclined to make sure it works if everything else is OK. But, always good to spend some time looking at it... |
There was a problem hiding this comment.
This is great, this improves the current code structure and removes some problematic logic in the code. I have a few questions on names, that we can discuss.
As a separate thing I'd like us to be thinking about what kind of design we'd like to have for FATES-SP that we can work towards. If we do some thinking there we can make sure steps like this are moving us toward what we think the end design goal might be. I think that should probably be an issue itself, where we put some design thinking in. So we should open that and reference here. This would just be thought of as a step toward that, and not doing everything desired there.
Happy to discuss and do more thinking about naming and a design goal to work towards.
But, thanks for the work here, I like that you are both fixing an immediate problem and improving the code. That's the golden thing to try to do when we can.
| real(r8) , pointer :: tlai_hist_patch (:) ! patch canopy one-sided leaf area index, for SP mode | ||
| real(r8) , pointer :: tsai_hist_patch (:) ! patch canopy one-sided stem area index, for SP mode | ||
| real(r8) , pointer :: htop_hist_patch (:) ! patch canopy height, for SP mode | ||
| real(r8) , pointer :: tlai_input_patch (:) ! patch canopy one-sided leaf area index driver data for SP mode (no burying by snow) |
There was a problem hiding this comment.
hist was a confusing suffix to have here, so I'm glad you are changing it. So input again means it's the value from the dataset?
There was a problem hiding this comment.
well yes, input, plus interpolated?
There is no baseline for this because it was not supposed to pass SHAREDLIB_BUILD (has an expected fail for that), but somehow it passed that stage but died in RUN |
adrifoster
changed the title
Description of changes
Creates a new data structure for
htop,tlai, andtsaithat is just driver data.Specific notes
Previously, fates used
htop_patch(etc.) as a driver data, but we also needed to update it and set sethtop_hist_patch. Thishtop_hist_patchwas inconsistently used throughout the CLM code, resulting in mis-matches between the PFT structures that we actually were trying to run (see #2945).Now we have the SP driver data as a separate data structure, and methods to set it. FATES sets it and passes it back to CLM through the
bc_outstruct, CLM just sets it in a 1:1 call.Contributors other than yourself, if any:
@ekluzek @rgknox @rosiealice
CTSM Issues Fixed (include github issue #): Closes #2945
Are answers expected to change (and if so in what way)? Yes - because we were incorrectly using it before, all FATES-SP compsets should change.
ALL OTHER COMPSETS SHOULD BE B4B
Any User Interface Changes (namelist or namelist defaults changes)? No
Does this create a need to change or add documentation? Did you do so? N/A
Testing performed, if any:
Will test