Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure FORTRAN code properly aborts when fire-emission is asked for and it can't be provided #2844

Draft
wants to merge 5 commits into
base: cesm3_0_beta04_changes
Choose a base branch
from

Conversation

ekluzek
Copy link
Collaborator

@ekluzek ekluzek commented Oct 23, 2024

Description of changes

Changes in the FORTRAN code to properly abort when fire-emission is asked for it can't be provided.

To develop this a PF unit test for CNFireFactoryMod is added in.

Specific notes

Contributors other than yourself, if any:

CTSM Issues Fixed (include github issue #):
Fixes #2762

Are answers expected to change (and if so in what way)? No

Any User Interface Changes (namelist or namelist defaults changes)? No

Does this create a need to change or add documentation? Did you do so? No

Testing performed, if any: Currently just the PF unit tests will run regular testing when done.

@ekluzek ekluzek added enhancement new capability or improved behavior of existing capability code health improving internal code structure to make easier to maintain (sustainability) bfb bit-for-bit usability Improve or clarify user-facing options labels Oct 23, 2024
@ekluzek ekluzek added this to the cesm3_0_beta05 milestone Oct 23, 2024
@ekluzek ekluzek self-assigned this Oct 23, 2024
@ekluzek ekluzek marked this pull request as draft October 23, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bfb bit-for-bit code health improving internal code structure to make easier to maintain (sustainability) enhancement new capability or improved behavior of existing capability usability Improve or clarify user-facing options
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Don't allow SP, fates, or nofire tests to turn fire_emis on (and make sure our tests don't do this either)
1 participant