Fix and improve anomaly forcings for ISSP cases #2686

samsrabin · 2024-08-13T18:19:25Z

Description of changes

Fixes a bug, and also makes it much simpler to run land-only SSP cases. Depends on ESCOMP/CDEPS#292.

Specific notes

Contributors other than yourself, if any: @ekluzek

CTSM Issues Fixed (include github issue #):

Fixes SSP cases get rcp45 anomalies #2301
Helps with Docs: Remove refs to DATM_CLMNCEP_YR_* and DATM_CPL_YR_* variables #2743

Are answers expected to change (and if so in what way)? Yes, for cases that were being bitten by #2301 before.

Any User Interface Changes (namelist or namelist defaults changes)? Yes; see ESCOMP/CDEPS#292.

Does this create a need to change or add documentation? Did you do so? Yes; yes.

Update docs

Testing performed, if any:

Existing datm_rcp45_anom_forc test unaffected as of 4b96267.
Existing datm_ssp126_anom_forc test unaffected as of c4ec313.

Remaining work

Pending complete ssp test suite: Remove datm_ssp*_anom_forc testmods, replacing tests using those with default
Resolve remaining TODO(s) in Running-with-anomaly-forcing.rst
In aux_clm suite, replace f09 ISSP126 test with 10x15 ISSP245 test? Would presumably be quicker to get through queue.
Delete tmp_scripts/.
Waiting on Fix and improve anomaly forcings for ISSP cases CDEPS#292: Point CDEPS external at updated tag.

Instead of having to specify anomaly_forcing = 'Anomaly.Forcing.Precip', 'Anomaly.Forcing.Temperature', etc.

Branch ssp-fix: Fix more typos of "anomaly."

Branch ssp-fix: Add Anomaly.Forcing.cmip6.ssp126.

ssp-fix branch: Add Anomaly.Forcing.cmip6.245, 370, 585.

Branch ssp-fix: Merge tag 'cdeps1.0.34' into ssp-fix

Branch ssp-fix: "anomaly_forcing now automatically set based on compset (ISSP*)." Also updates testmods accordingly.

Branch ssp-fix: Now actually sets anomaly_forcing based on compset.

Branch ssp-fix: Only set anomaly_forcing for DATM SSP compsets.

Branch ssp-fix: Provide hint in error message if namelist variable invalid due to surrounding quote marks.

Branch ssp-fix: Make datm buildnml more robust.

To match what's run in aux_clm.

Branch ssp-fix: Bugfix to future-proofing of datm buildnml.

samsrabin · 2024-10-08T19:21:32Z

Marking as blocked while I wait on the ESCOMP/CDEPS#292 PR.

samsrabin · 2024-11-04T17:24:57Z

@ekluzek Requesting your review as discussed. Note, however, that this is blocked until the CDPS-side PR (ESCOMP/CDEPS#292) is done. I don't have permissions to request your review there.

ekluzek

Really glad to see this coming in, and appreciate all the work here. I have quite a few suggestions on changes. So we should meet to discuss this and the CDEPS PR.

ekluzek · 2024-11-05T19:26:47Z

.gitmodules

-url = https://github.com/ESCOMP/CDEPS.git
-fxtag = cdeps1.0.34
+url = https://github.com/samsrabin/CDEPS.git
+fxtag = 25c7b920de8fdf1a90b00276a0d7b003b4a845a9


This of course will need to change once we have a tag here.

I did review the CDEPS PR as well, and have quite a few suggestions there.

ekluzek · 2024-11-05T19:27:46Z

cime_config/testdefs/testlist_clm.xml

@@ -1989,6 +1989,7 @@
    <machines>
      <machine name="izumi" compiler="intel" category="aux_clm"/>
      <machine name="derecho" compiler="nvhpc" category="aux_clm"/>
+      <machine name="derecho" compiler="nvhpc" category="ssp"/>


Ahhh, adding a new testlist for ssp. That sounds interesting.

I do suggest that you use intel or gnu here though, as we know there are problems with nvhpc.

ekluzek · 2024-11-05T19:29:27Z

cime_config/testdefs/testlist_clm.xml

@@ -2513,15 +2514,46 @@
      <option name="comment"  >Transient production future scenario SSP3-7.0 case with isotopes with a december 2050 start</option>
    </options>
  </test>
-  <test name="SMS_D_Ld5" grid="f09_g17" compset="ISSP126Clm50BgcCrop" testmods="clm/datm_ssp126_anom_forc">
+
+  <test name="SMS_D_Ld5" grid="f09_g17" compset="ISSP126Clm50BgcCrop" testmods="clm/default">


We actually shouldn't have a testmod for this. We want to have this handled based on the compset, so you shouldn't need a testmod for it.

Or is this something particular about the ssp126 case? You don't do this with the other SSP's below...

ekluzek · 2024-11-05T19:30:14Z

cime_config/testdefs/testlist_clm.xml

    </machines>
    <options>
      <option name="wallclock">00:20:00</option>
      <option name="comment"  >Transient production with anomaly forcing future scenario SSP1-2.6 case</option>
    </options>
  </test>
+  <test name="SMS_D_Ld5" grid="f10_f10_mg37" compset="ISSP245Clm50BgcCrop" testmods="clm/default">
+    <machines>
+      <machine name="derecho" compiler="intel" category="ssp"/>


I think maybe we add this one to aux_clm as well.

ekluzek · 2024-11-05T19:33:25Z

cime_config/testdefs/testmods_dirs/clm/datm_rcp45_anom_forc/user_nl_clm

@@ -0,0 +1 @@
+flanduse_timeseries = '$DIN_LOC_ROOT/lnd/clm2/surfdata_esmf/ctsm5.2.0/landuse.timeseries_0.9x1.25_SSP2-4.5_1850-2100_78pfts_c240216.nc'


You shouldn't need to do this. And you are asking for the ctsm5.2 dataset, which isn't going to work.

So I think this testmod should be removed. But, I might be missing something.

ekluzek · 2024-11-05T19:39:40Z

tmp_scripts/make_allvars_files.sh

@@ -0,0 +1,46 @@
+#!/bin/bash
+set -e


What are these two scripts about? Something temporary needed while the PR is created and then removed at the last moment?

If so that's an interesting strategy that sounds useful.

ekluzek · 2024-11-05T19:48:43Z

doc/source/users_guide/running-special-cases/Running-with-anomaly-forcing.rst


-Users may wish to also update files such as the landuse\_timeseries and aerosol and Ndepostion files to correspond to the appropriate SSP.
+TODO: IS THIS ACTUALLY NEEDED?


Good question.

It could be worth trying it without it to make sure it is required for all the fields. Setting it for some fields was required in the past, but may not be anymore.

ekluzek · 2024-11-05T19:51:17Z

doc/source/users_guide/running-special-cases/Running-with-anomaly-forcing.rst

@@ -5,41 +5,69 @@
 ==============================
 Running with anomaly forcing
 ==============================
-Because performing fully coupled climate simulations is computationally expensive, an alternate method of running land-only simulations forced by future climate projections was developed for CTSM called 'anomaly forcing'.  The anomaly forcing method uses a previously completed fully coupled simulation to create monthly anomalies, relative to the present day, of near-surface atmospheric states and fluxes.  These anomalies, representing the evolution of future climate projections, are applied to a repeating cycle of present day atmospheric forcing data, either as an additive (for states) or multiplicative (for fluxes) quantity.  Thus, high-frequency variability is obtained from the present day atmospheric forcing data, while the long-term evolution of the climate is determined by the anomaly forcing dataset.
+Because performing fully coupled climate simulations is computationally expensive, an alternate method of running land-only simulations forced by future climate projections was developed for CTSM called "anomaly forcing." The anomaly forcing method uses a previously-completed, fully-coupled simulation to create monthly anomalies, relative to the present day, of near-surface atmospheric states and fluxes. These anomalies, representing the evolution of future climate projections, are applied to a repeating cycle of present day atmospheric forcing data, either as an additive (for states) or multiplicative (for fluxes) quantity. Thus, high-frequency variability is obtained from the present day atmospheric forcing data, while the long-term evolution of the climate is determined by the anomaly forcing dataset.


These documentation changes all look good to me, and I'm glad you went ahead and handled it.

ekluzek · 2024-11-05T21:18:34Z

I'm just reviewing this, so I took my name off the assignee for it.

samsrabin added 16 commits May 3, 2024 15:08

Point CDEPS external at cdeps1.0.33.

208c594

Update other externals after CESM tag cesm2_3_alpha17e.

8d628f2

Add datm_rcp45_anom_forc testmod.

702477d

Point CDEPS external at my branch, with Anomaly.Forcing.cmip5.rcp45.

f59d045

datm_rcp45_anom_forc testmod now uses Anomaly.Forcing.cmip5.rcp45.

662e536

Instead of having to specify anomaly_forcing = 'Anomaly.Forcing.Precip', 'Anomaly.Forcing.Temperature', etc.

Added a few scripts for this work

8df08ff

Remove user_nl_datm_streams from datm_rcp45_anom_forc testmod.

1416363

Update CDEPS external to 462c7a9.

4b96267

Branch ssp-fix: Fix more typos of "anomaly."

Update CDEPS external to 759c591.

825fbb6

Branch ssp-fix: Add Anomaly.Forcing.cmip6.ssp126.

datm_ssp126_anom_forc testmod now uses Anomaly.Forcing.cmip6.ssp126.

496c154

Add 'ssp' test suite.

0a8df10

Update CDEPS external to 84669d7.

634cfce

ssp-fix branch: Add Anomaly.Forcing.cmip6.245, 370, 585.

Add testmods for ssp245, 370, 585.

42b7575

Add ssp suite tests for 245, 370, 585.

567fcad

Merge remote-tracking branch 'escomp/b4b-dev' into ssp-anomaly-fixes

597a4de

Update CDEPS external to 547506603e.

c4ec313

Branch ssp-fix: Merge tag 'cdeps1.0.34' into ssp-fix

samsrabin added the bug something is working incorrectly label Aug 13, 2024

samsrabin self-assigned this Aug 13, 2024

samsrabin added the usability Improve or clarify user-facing options label Aug 27, 2024

samsrabin added 2 commits September 5, 2024 08:16

Update CDEPS external to 3f36622.

49382ee

Branch ssp-fix: "anomaly_forcing now automatically set based on compset (ISSP*)." Also updates testmods accordingly.

Update CDEPS external to 797b320.

728257b

Branch ssp-fix: Now actually sets anomaly_forcing based on compset.

samsrabin force-pushed the ssp-anomaly-fixes branch from 0a71fe6 to 728257b Compare September 5, 2024 15:43

samsrabin and others added 8 commits September 5, 2024 13:02

Update CDEPS external to 274b06b.

4da4587

Branch ssp-fix: Only set anomaly_forcing for DATM SSP compsets.

Update "Running with anomaly forcing" doc for latest CDEPS.

51a8e1b

Running-with-anomaly-forcing.rst: Formatting improvements.

1644c61

Running-with-anomaly-forcing.rst: Resolve a TODO.

5aae2a6

Running-with-anomaly-forcing.rst: Update single-pt instructions.

a2fc1c1

Update CDEPS external to 1e403a8.

f514ed8

Branch ssp-fix: Provide hint in error message if namelist variable invalid due to surrounding quote marks.

Update CDEPS external to b1f17519.

da2f4e8

Branch ssp-fix: Make datm buildnml more robust.

Remove datm_ssp*_anom_forc testmods.

8cb5854

samsrabin added 2 commits September 5, 2024 15:36

Replace non-SSP test in ssp suite with nvhpc version.

01967bf

To match what's run in aux_clm.

Update CDEPS external to 25c7b92.

124027b

Branch ssp-fix: Bugfix to future-proofing of datm buildnml.

samsrabin added the enhancement new capability or improved behavior of existing capability label Sep 5, 2024

samsrabin added blocked: dependency Wait to work on this until dependency is resolved external issue needs to be addressed elsewhere (submodule); issue here for the sake of project tracking labels Oct 8, 2024

samsrabin requested a review from ekluzek November 4, 2024 17:23

samsrabin assigned ekluzek Nov 4, 2024

ekluzek requested changes Nov 5, 2024

View reviewed changes

ekluzek removed their assignment Nov 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix and improve anomaly forcings for ISSP cases #2686

Fix and improve anomaly forcings for ISSP cases #2686

samsrabin commented Aug 13, 2024 •

edited

Loading

samsrabin commented Oct 8, 2024

samsrabin commented Nov 4, 2024

ekluzek left a comment

ekluzek Nov 5, 2024

ekluzek Nov 5, 2024

ekluzek Nov 5, 2024

ekluzek Nov 5, 2024

ekluzek Nov 5, 2024

ekluzek Nov 5, 2024

ekluzek Nov 5, 2024

ekluzek Nov 5, 2024

ekluzek Nov 5, 2024

ekluzek Nov 5, 2024

ekluzek commented Nov 5, 2024

		@@ -0,0 +1 @@
		flanduse_timeseries = '$DIN_LOC_ROOT/lnd/clm2/surfdata_esmf/ctsm5.2.0/landuse.timeseries_0.9x1.25_SSP2-4.5_1850-2100_78pfts_c240216.nc'


		Users may wish to also update files such as the landuse\_timeseries and aerosol and Ndepostion files to correspond to the appropriate SSP.
		TODO: IS THIS ACTUALLY NEEDED?

Fix and improve anomaly forcings for ISSP cases #2686

Are you sure you want to change the base?

Fix and improve anomaly forcings for ISSP cases #2686

Conversation

samsrabin commented Aug 13, 2024 • edited Loading

Description of changes

Specific notes

Remaining work

samsrabin commented Oct 8, 2024

samsrabin commented Nov 4, 2024

ekluzek left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ekluzek commented Nov 5, 2024

samsrabin commented Aug 13, 2024 •

edited

Loading