Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup cesm log #2717

Open
jedwards4b opened this issue Aug 21, 2024 · 2 comments · Fixed by #2927
Open

cleanup cesm log #2717

jedwards4b opened this issue Aug 21, 2024 · 2 comments · Fixed by #2927
Labels
bfb bit-for-bit code health improving internal code structure to make easier to maintain (sustainability) done Issues whose closing PR is done but not yet merged (pending test re-run ok) enhancement new capability or improved behavior of existing capability good first issue simple; good for first-time contributors
Milestone
ctsm6.0.0 (code f...

Comments

@jedwards4b
Copy link
Contributor

In file https://github.com/ESCOMP/CTSM/blob/master/src/soilbiogeochem/CNSoilMatrixMod.F90#L67
output to the log should be restricted to the root task. We don't need to know this from every task:

CN Soil matrix solution is off
@ekluzek ekluzek added enhancement new capability or improved behavior of existing capability good first issue simple; good for first-time contributors next this should get some attention in the next week or two. Normally each Thursday SE meeting. bfb bit-for-bit labels Aug 21, 2024
@samsrabin samsrabin removed the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Aug 22, 2024
@samsrabin
Copy link
Collaborator

Good point, thanks Jim!

@samsrabin samsrabin added the code health improving internal code structure to make easier to maintain (sustainability) label Aug 22, 2024
@wwieder
Copy link
Contributor

wwieder commented Aug 22, 2024

Thanks for noting this Jim. We'll get it on a b4b tag soon.

@samsrabin samsrabin added this to the ctsm6.0.0 (code freeze) milestone Aug 22, 2024
@samsrabin samsrabin mentioned this issue Oct 17, 2024
Open
3 tasks
@samsrabin samsrabin mentioned this issue Jan 8, 2025
Merged
1 task
@samsrabin samsrabin linked a pull request Jan 27, 2025 that will close this issue
Reduce log noise #2927
Merged
1 task
@samsrabin samsrabin added the done Issues whose closing PR is done but not yet merged (pending test re-run ok) label Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bfb bit-for-bit code health improving internal code structure to make easier to maintain (sustainability) done Issues whose closing PR is done but not yet merged (pending test re-run ok) enhancement new capability or improved behavior of existing capability good first issue simple; good for first-time contributors
Projects
None yet
Milestone
ctsm6.0.0 (code freeze)
Development

Successfully merging a pull request may close this issue.

Reduce log noise samsrabin/CTSM
4 participants
@jedwards4b @wwieder @samsrabin @ekluzek