Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce log message noise #2736

Open
3 tasks done
samsrabin opened this issue Aug 29, 2024 · 5 comments · Fixed by #2927
Open
3 tasks done

Reduce log message noise #2736

samsrabin opened this issue Aug 29, 2024 · 5 comments · Fixed by #2927
Assignees
Labels
bfb bit-for-bit done Issues whose closing PR is done but not yet merged (pending test re-run ok) enhancement new capability or improved behavior of existing capability good first issue simple; good for first-time contributors

Comments

@samsrabin
Copy link
Collaborator

samsrabin commented Aug 29, 2024

As discussed at CSEG meeting 2024-06-18, reducing unnecessary messaging is a CSEG goal for CESM3.

Things to consider for each message:

  • Is it needed at all?
  • Can it be changed to only show if the XML DEBUG setting is true? (By wrapping in #ifndef NDEBUG/#endif)
  • If it's currently in cesm.log, should it be moved to lnd.log?
  • If every process is printing it, can it be set so that just the primary process does?

Messages to consider:

  • clm: leaving fates model (lnd.log, every process)—especially strange considering there's no "entering" message. Get rid of this
  • CN Soil matrix solution is off (cesm.log, every process) get rid of this (also filed at cleanup cesm log #2717)
  • pes participating in computation for CLM and table (lnd.log), maybe we keep this? yes
  • Init2: calling FireInit (cesm.log, every process)
@samsrabin samsrabin added enhancement new capability or improved behavior of existing capability bfb bit-for-bit labels Aug 29, 2024
@samsrabin samsrabin changed the title Disable "clm: leaving fates model" message Disable unnecessary log messages Sep 4, 2024
@samsrabin samsrabin changed the title Disable unnecessary log messages Reduce log message noise Sep 4, 2024
@samsrabin samsrabin added the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Sep 5, 2024
@wwieder wwieder removed the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Sep 5, 2024
@samsrabin samsrabin added good first issue simple; good for first-time contributors and removed simple labels Oct 3, 2024
@jedwards4b
Copy link
Contributor

Noting that this still has not been addressed as of ctsm5.3.014

@wwieder
Copy link
Contributor

wwieder commented Jan 6, 2025

@samsrabin is this something that can be easily addressed and put on b4b-dev?

@samsrabin
Copy link
Collaborator Author

Yes, definitely. However, I'll need to wait until b4b-dev gets the eventual fix to the Izumi nag failures introduced (probably) with the Bytnerowicz update.

@wwieder
Copy link
Contributor

wwieder commented Jan 7, 2025

Makes sense. Seems like the nag bug will be addressed this week

@ekluzek
Copy link
Collaborator

ekluzek commented Jan 7, 2025

@wwieder and @samsrabin we just merged the fix to b4b-dev. So b4b-dev is ready to have PR's added to it again.

@samsrabin samsrabin mentioned this issue Jan 8, 2025
1 task
@samsrabin samsrabin linked a pull request Jan 27, 2025 that will close this issue
1 task
@samsrabin samsrabin added the done Issues whose closing PR is done but not yet merged (pending test re-run ok) label Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bfb bit-for-bit done Issues whose closing PR is done but not yet merged (pending test re-run ok) enhancement new capability or improved behavior of existing capability good first issue simple; good for first-time contributors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants