fix issues in refactor #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jedwards4b @billsacks @Katetc - I'd really like the fix to the restarts to go in its own PR - particularly since I want to make sure that the results are bfb with the restart change. Can this please be done and have Kate's PR come in separately. I think that would be much cleaner and also important for me to use in my current NorESM simulations. |
mvertens
approved these changes
Sep 4, 2024
mvertens
reviewed
Sep 4, 2024
dglc/dglc_datamode_noevolve_mod.F90
Outdated
| allocate(gindex(lsize)) | ||
| call ESMF_DistGridGet(distGrid, localDe=0, seqIndexList=gindex, rc=rc) | ||
| if (ChkErr(rc,__LINE__,u_FILE_u)) return | ||
|
|
||
| call pio_initdecomp(pio_subsystem, pio_double, (/nx_global(ns),ny_global(ns)/), gindex, pio_iodesc) | ||
| call pio_write_darray(pioid, varid, pio_iodesc, Fgrg_rofi(ns)%ptr, rcode, fillval=shr_const_spval) |
There was a problem hiding this comment.
This is incorrect in that varid should be an array and not a scalar. How does this ever work for multiple ice sheets?
There was a problem hiding this comment.
This refers to line 510 above which was not modified and I think should be.
mvertens
requested changes
Sep 4, 2024
Katetc
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Fix issues in restart of multiple ice sheets.
Specific notes
Contributors other than yourself, if any:
CDEPS Issues Fixed (include github issue #):
Are there dependencies on other component PRs (if so list):
Are changes expected to change answers (bfb, different to roundoff, more substantial):
Any User Interface Changes (namelist or namelist defaults changes):
Testing performed (e.g. aux_cdeps, CESM prealpha, etc):
Hashes used for testing: