Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not fixed: ASAP bug fixes for cam_dev restarts and irreproducible results #659

Closed

Conversation

cacraigucar
Copy link
Collaborator

@cacraigucar cacraigucar commented Sep 26, 2022

This PR is being closed without fixing as it was determined that since there were unexpected answer changes, each PR/issue would be brought in separately. This PR does contain the reviews for #660 and #666.

In addition to fixing cam_dev restarts and the irreproducible results issues, this PR will also bring in some interpolate_output SE bug fixes.

#655 was going to be closed
#631 was going to be closed
#658 was going to be closed

#660 was going to be closed
#644 was going to be closed

@cacraigucar cacraigucar marked this pull request as draft September 26, 2022 17:13
@cacraigucar cacraigucar added the bug-fix This PR was created to fix a specific bug. label Sep 26, 2022
@cacraigucar cacraigucar added this to the CAM6.5 milestone Sep 26, 2022
@cacraigucar cacraigucar marked this pull request as ready for review September 27, 2022 19:06
Copy link
Collaborator

@nusbaume nusbaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me (ignoring the ChangeLog which I didn't review). Thanks!

Copy link

@fvitt fvitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems okay to me.

Copy link
Collaborator

@jtruesdal jtruesdal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay just had to brush up on passing optional arguments to a procedure without checking that it is present. All looks good.

@adamrher
Copy link

I'm sure this is on someone's todo list, but this PR needs to be cleaned-up. It only needs to address two issues: #644 and #658. All others mentioned are addressed through different PRs. Also the "Close #660" should be removed as this is linking to a PR, and not an issue.

@cacraigucar
Copy link
Collaborator Author

cacraigucar commented Sep 30, 2022

@adamrher - Yes, this PR morphed from encompassing several issues/PRs to actually being closed without being used at all. An FYI, if we had used this PR, then it would have been closing issues as well as PRs as it would have brought in #660 along with other changes. Now each will be in their own PR.

This PR contains the reviews for #660 and #666

@cacraigucar cacraigucar changed the title ASAP bug fixes for cam_dev restarts and irreproducible results Not fixed: ASAP bug fixes for cam_dev restarts and irreproducible results Oct 3, 2022
@peverwhee peverwhee mentioned this pull request Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix This PR was created to fix a specific bug.
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

7 participants