-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not fixed: ASAP bug fixes for cam_dev restarts and irreproducible results #659
Not fixed: ASAP bug fixes for cam_dev restarts and irreproducible results #659
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me (ignoring the ChangeLog which I didn't review). Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems okay to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay just had to brush up on passing optional arguments to a procedure without checking that it is present. All looks good.
@adamrher - Yes, this PR morphed from encompassing several issues/PRs to actually being closed without being used at all. An FYI, if we had used this PR, then it would have been closing issues as well as PRs as it would have brought in #660 along with other changes. Now each will be in their own PR. |
This PR is being closed without fixing as it was determined that since there were unexpected answer changes, each PR/issue would be brought in separately. This PR does contain the reviews for #660 and #666.
In addition to fixing cam_dev restarts and the irreproducible results issues, this PR will also bring in some interpolate_output SE bug fixes.
#655 was going to be closed
#631 was going to be closed
#658 was going to be closed
#660 was going to be closed
#644 was going to be closed