Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for ZM round 4 #345

Open
wants to merge 25 commits into
base: development
Choose a base branch
from

Conversation

cacraigucar
Copy link
Collaborator

Tag name (required for release branches):
Originator(s): cacraig, peverley, nusbaume

Description (include the issue title, and the keyword ['closes', 'fixes', 'resolves'] followed by the issue number):

  • No issue made
  • Adds mods from various developers to get ZM to work properly in CAM-SIMA

Describe any changes made to build system: N/A

Describe any changes made to the namelist: N/A

List any changes to the defaults for the input datasets (e.g. boundary datasets): N/A

List all files eliminated and why: N/A

List all files added and what they do: N/A

List all existing files that have been modified, and describe the changes:
(Helpful git command: git diff --name-status development...<your_branch_name>)
M cime_config/atm_in_paramgen.py
M src/data/physconst.meta
M src/data/ref_pres.meta
M src/data/registry.xml
M src/physics/ncar_ccpp
M src/physics/utils/phys_comp.F90
A src/physics/utils/ppgrid.F90
M src/utils/time_manager.F90
M test/unit/sample_files/write_init_files/physics_inputs_4D.F90
M test/unit/sample_files/write_init_files/physics_inputs_bvd.F90
M test/unit/sample_files/write_init_files/physics_inputs_cnst.F90
M test/unit/sample_files/write_init_files/physics_inputs_ddt.F90
M test/unit/sample_files/write_init_files/physics_inputs_ddt2.F90
M test/unit/sample_files/write_init_files/physics_inputs_ddt_array.F90
M test/unit/sample_files/write_init_files/physics_inputs_host_var.F90
M test/unit/sample_files/write_init_files/physics_inputs_mf.F90
M test/unit/sample_files/write_init_files/physics_inputs_no_horiz.F90
M test/unit/sample_files/write_init_files/physics_inputs_protect.F90
M test/unit/sample_files/write_init_files/physics_inputs_scalar.F90
M test/unit/sample_files/write_init_files/physics_inputs_simple.F90

If there are new failures (compared to the test/existing-test-failures.txt file),
have them OK'd by the gatekeeper, note them here, and add them to the file.
If there are baseline differences, include the test and the reason for the
diff. What is the nature of the change? Roundoff?

derecho/intel/aux_sima:

derecho/gnu/aux_sima:

If this changes climate describe any run(s) done to evaluate the new
climate in enough detail that it(they) could be reproduced:

CAM-SIMA date used for the baseline comparison tests if different than latest:

@cacraigucar cacraigucar self-assigned this Jan 3, 2025
Copy link
Member

@jimmielin jimmielin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cacraigucar! I had a couple questions on the physics_types naming and another regarding a subroutine call change, hopefully easy to address.

src/data/registry.xml Outdated Show resolved Hide resolved
src/data/registry.xml Outdated Show resolved Hide resolved
src/physics/utils/phys_comp.F90 Show resolved Hide resolved
Copy link
Collaborator Author

@cacraigucar cacraigucar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe we should change either of the names that @jimmielin has concerns about since changes would need to be made is ESCOMP/CAM and ESCOMP/atmospheric_physics, though I am open to being overruled.

src/data/registry.xml Outdated Show resolved Hide resolved
src/data/registry.xml Outdated Show resolved Hide resolved
src/physics/utils/phys_comp.F90 Show resolved Hide resolved
@cacraigucar cacraigucar requested a review from jimmielin January 27, 2025 23:03
Copy link
Member

@jimmielin jimmielin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cacraigucar for addressing my comments!

@@ -35,7 +35,7 @@
dimensions = ()
protected = True
[ trop_cloud_top_lev ]
standard_name = index_of_pressure_at_troposhere_cloud_top
standard_name = index_of_pressure_at_troposphere_cloud_top
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be updated to vertical_layer_index_of_troposphere_cloud_top since it looks like atmos_phys cloud_fraction_fice expects vertical_layer_index_of_troposphere_cloud_top? (https://github.com/ESCOMP/atmospheric_physics/blob/development/schemes/cloud_fraction/cloud_fraction_fice.meta#L27)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants