Update substitutions if a column is transformed #1848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well done @fwesselm ! Have a good break |
…olveBugTransform
|
Testing shows that HiGHS behavior is not affected by the code changes in this PR (on 800+ problems from MIPLIB, etc.). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a column is transformed in presolve (complemented and/or shifted), variable bound constraints are updated accordingly. However, substitutions that may be affected are currently not updated. I think this is a bug, and I fixed this.
This should partly fix #1578, in particular the incorrect answer on
Civ4.100.turns(mentioned here).I did not do large-scale testing so far. @jajhall, I am away for the next 2 weeks and I could do the testing when I return.