Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Meson highs 1.7.x #1749

Closed
wants to merge 24 commits into from
Closed

Conversation

HaoZeke
Copy link
Contributor

@HaoZeke HaoZeke commented May 5, 2024

Should supersede #1405. Draft until:

What's inside (why merge):

  • Meson build for highspy (needed for SciPy)
  • Minor fixes to reduce warnings, so the following are no longer needed:
    • -Wno-return-type
    • -Wno-switch
    • -Wno-comment
    • -Wno-unused-const-variable
    • -Wno-unused-function

@HaoZeke HaoZeke force-pushed the meson_highs_1.7.0 branch 4 times, most recently from 1599e75 to 0aae23d Compare May 5, 2024 13:21
@HaoZeke HaoZeke changed the title ENH: Meson highs 1.7.0 ENH: Meson highs 1.7.x May 5, 2024
@HaoZeke
Copy link
Contributor Author

HaoZeke commented May 5, 2024

For the windows python issues we might have to wait on mesonbuild/meson#13167

EDIT: No, not really because pybind11 doesn't support this anyway pybind/pybind11#1755

@HaoZeke HaoZeke force-pushed the meson_highs_1.7.0 branch 2 times, most recently from 20189fb to faaa382 Compare May 5, 2024 14:16
@HaoZeke HaoZeke force-pushed the meson_highs_1.7.0 branch 19 times, most recently from b6db26c to 76533fd Compare May 19, 2024 22:54
@HaoZeke
Copy link
Contributor Author

HaoZeke commented May 20, 2024

I think, after the conversation with @galabovaa and @jajhall I'll just refocus this to work with SciPy. The Windows build "works" with careful handling of delvewheel but that's about as far as is needed since the team will keep scikit-build as the primary build system.

EDIT: ETA next week.

In any case it is better to be consistent here
@HaoZeke HaoZeke marked this pull request as ready for review July 20, 2024 23:31
@HaoZeke
Copy link
Contributor Author

HaoZeke commented Sep 16, 2024

Closing in favor of another PR (in a few min)

@HaoZeke HaoZeke closed this Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant