Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: index selector over value in Executed event #246

Merged
merged 1 commit into from
Nov 27, 2023
Merged

refactor: index selector over value in Executed event #246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions docs/ERC-725.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,15 +139,15 @@ _Returns:_ `bytes[]` , array list of returned data of the called function, or th
#### Executed

```solidity
event Executed(uint256 indexed operationType, address indexed target, uint256 indexed value, bytes4 data);
event Executed(uint256 indexed operationType, address indexed target, uint256 value, bytes4 indexed selector);
```

MUST be triggered when `execute` creates a new call using the `operationType` `0`, `3`, `4`.

#### ContractCreated

```solidity
event ContractCreated(uint256 indexed operationType, address indexed contractAddress, uint256 indexed value, bytes32 salt);
event ContractCreated(uint256 indexed operationType, address indexed contractAddress, uint256 value, bytes32 indexed salt);
```

MUST be triggered when `execute` creates a new contract using the `operationType` `1`, `2`.
Expand Down Expand Up @@ -283,8 +283,8 @@ When using the operation type `4` for `delegatecall`, it is important to conside
pragma solidity >=0.5.0 <0.7.0;

interface IERC725X /* is ERC165, ERC173 */ {
event ContractCreated(uint256 indexed operationType, address indexed contractAddress, uint256 indexed value, bytes32 salt);
event Executed(uint256 indexed operationType, address indexed target, uint256 indexed value, bytes4 data);
event ContractCreated(uint256 indexed operationType, address indexed contractAddress, uint256 value, bytes32 indexed salt);
event Executed(uint256 indexed operationType, address indexed target, uint256 value, bytes4 indexed selector);

function execute(uint256 operationType, address target, uint256 value, bytes memory data) external payable returns(bytes memory);

Expand Down
8 changes: 4 additions & 4 deletions implementations/constants.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,8 @@ const EventSignatures = {
* event ContractCreated(
* uint256 indexed _operation,
* address indexed _contractAddress,
* uint256 indexed _value
* bytes32 _salt
* uint256 _value
* bytes32 indexed _salt
* );
*
* signature = keccak256('ContractCreated(uint256,address,uint256,bytes32)')
Expand All @@ -84,8 +84,8 @@ const EventSignatures = {
* event Executed(
* uint256 indexed _operation,
* address indexed _to,
* uint256 indexed _value,
* bytes4 _data
* uint256 _value,
* bytes4 indexed _selector
* );
*
* signature = keccak256('Executed(uint256,address,uint256,bytes4)')
Expand Down
8 changes: 4 additions & 4 deletions implementations/contracts/interfaces/IERC725X.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ interface IERC725X is IERC165 {
event ContractCreated(
uint256 indexed operationType,
address indexed contractAddress,
uint256 indexed value,
bytes32 salt
uint256 value,
bytes32 indexed salt
);

/**
Expand All @@ -38,8 +38,8 @@ interface IERC725X is IERC165 {
event Executed(
uint256 indexed operationType,
address indexed target,
uint256 indexed value,
bytes4 selector
uint256 value,
bytes4 indexed selector
);

/**
Expand Down
Loading