test: add more tests for ERC725 to ensure it supports both X and Y …

…interfaces
ERC725Alliance · Sep 8, 2024 · 4acb584 · 4acb584
1 parent 2012cd2
commit 4acb584
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 3 deletions.
diff --git a/implementations/test/ERC725.test.ts b/implementations/test/ERC725.test.ts
@@ -64,6 +64,22 @@ describe('ERC725', () => {
 
         expect(await ethers.provider.getBalance(contract.address)).to.equal(deployParams.funding);
       });
+
+      it('should have registered the ERC725X & ERC725Y interfaces', async () => {
+        const accounts = await ethers.getSigners();
+
+        const deployParams = {
+          newOwner: accounts[0].address,
+          funding: ethers.utils.parseEther('10'),
+        };
+
+        const contract = await new ERC725__factory(accounts[0]).deploy(deployParams.newOwner, {
+          value: deployParams.funding,
+        });
+
+        expect(await contract.supportsInterface(INTERFACE_ID.ERC725X)).to.be.true;
+        expect(await contract.supportsInterface(INTERFACE_ID.ERC725X)).to.be.true;
+      });
     });
   });
 
@@ -105,7 +121,11 @@ describe('ERC725', () => {
       });
 
       it('should have registered the ERC725X interface', async () => {
-        expect(await context.erc725.supportsInterface(INTERFACE_ID.ERC725X));
+        expect(await context.erc725.supportsInterface(INTERFACE_ID.ERC725X)).to.be.true;
+      });
+
+      it('should have registered the ERC725Y interface', async () => {
+        expect(await context.erc725.supportsInterface(INTERFACE_ID.ERC725Y)).to.be.true;
       });
 
       it('should revert when initializing with address(0) as owner', async () => {

diff --git a/implementations/test/ERC725X.behaviour.ts b/implementations/test/ERC725X.behaviour.ts
@@ -2185,7 +2185,7 @@ export const shouldInitializeLikeERC725X = (
     });
 
     it('should have registered the ERC725X interface', async () => {
-      expect(await context.erc725X.supportsInterface(INTERFACE_ID.ERC725X));
+      expect(await context.erc725X.supportsInterface(INTERFACE_ID.ERC725X)).to.be.true;
     });
 
     it('should have set the correct owner', async () => {

diff --git a/implementations/test/ERC725Y.behaviour.ts b/implementations/test/ERC725Y.behaviour.ts
@@ -840,7 +840,7 @@ export const shouldInitializeLikeERC725Y = (
     });
 
     it('should have registered the ERC725Y interface', async () => {
-      expect(await context.erc725Y.supportsInterface(INTERFACE_ID.ERC725Y));
+      expect(await context.erc725Y.supportsInterface(INTERFACE_ID.ERC725Y)).to.be.true;
     });
   });
 };