Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement second derivative for Hermite splines #30

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Conversation

faymanns
Copy link
Member

@faymanns faymanns commented Oct 9, 2024

In the original version, the CubicHermite and the ExponentialHermite basis functions where implemented as not twice differentiable, but they are in fact twice differentiable. They are just not C2. Since some of the non-Hermite basis functions are also not C2 but we have implemented the second derivative, we should also do this for the Hermite splines.

Even though the second derivatives are not continuous, having them will be useful to compute curvature and bending energy.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.48%. Comparing base (9583f0b) to head (edd5d10).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #30      +/-   ##
==========================================
- Coverage   98.49%   98.48%   -0.01%     
==========================================
  Files           3        3              
  Lines         530      528       -2     
==========================================
- Hits          522      520       -2     
  Misses          8        8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@faymanns faymanns merged commit d6ccb70 into main Oct 14, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants