-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Style Parsing #164
Merged
Merged
Style Parsing #164
Changes from 4 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
4561f2b
feat: add ol-mapbox-style
RobertOrthofer 8de8aac
chore: update package-lock
RobertOrthofer 97500f7
feat: enable parsing of mapbox style
RobertOrthofer f35b333
test: test for correct style parsing
RobertOrthofer 03cc4df
feat: consider flatStyles
RobertOrthofer 303874a
test: update tests for mapbox and flatstyles
RobertOrthofer ff4de5e
feat: use all draw options, allowing sketch style
RobertOrthofer a6639ab
chore: update ol
RobertOrthofer 509dda0
chore: update package-lock
RobertOrthofer 4fb83d9
feat: fix mapbox styles for vector tiles
RobertOrthofer e839e23
chore: linting
RobertOrthofer 70fc4ef
Merge branch 'map/main' into map/feature/styles
silvester-pari 8ed00a8
chore: formatting
silvester-pari File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be great if here in the test we could use a minimal example to show what the minimum fields are to make this work. I understand that
version
is necessary, but other things are not. Also, thesource
name does not need to match the layer id, maybe it's better to explicitly show this in the test, for example:Maybe, for convenience, the
source
property could be automatically generated with an arbitrary string, since it serves no purpose. Or am I missing a functionality here?