Colors

[nicolaje]

Adds long awaited:

• line styling and sizing : by properties : .."LineStyle",":","LineWidth",4.2... or by format "darkRed-..[blue]"
• all colors naming from http://www.w3.org/TR/SVG/types.html#ColorKeywords
• custom RGB/RGBA color setting : by properties : .."FaceColor",(vibes::RGBA){100,100,1,255}... or by format : "mediumslateblue-..[255,42,35,12]"

Are you OK with this format?

How would you like to specify a lineWidth in the format?
for example, to set a 12 width line with : style, blue edges, white face, possibilities are:

• "@12@:blue[white]"
• "{12}:blue[white]
• ?? suggestions

Should we add a way to specify transparency for named colors in the format?

@dvinc @SimonRohou @ThomasLeMezo @msis @ClementAubry

[nicolaje]

@benEnsta could you check why your proposition for coloration using #RGB isn't integrated?

[benEnsta]

I checked my code, with your proposition coloration using #RGB or #RRGGBB works without any problem.

However I wonder why the new brush (or pen) aren't saved in the _brush QHash list because it avoid to instantiate a new brush for each item.
I created a pull request with my old code which handles colors and transparency, may be some idea can be taken.

[nicolaje]

Agreed, I just didn't want to copy/paste the 149 color names, but I will.

[benEnsta]

I think you don't have to copy color names. Just instead of directly return the new color object, you should add it to _brush. You should also check if the color exist in _bruch before. So if the color already exist in the QHash return the brush else add the new color.

[nicolaje]

I see what you mean, I will do it this way.

[nicolaje]

Done. If nobody disagrees with the RGBA color settings command, I will merge this pull request by the end of the week.

[nicolaje]

I actually don't like passing RGB/A colors in the "format" field.
To keep it "Matlab simple", it is preferable to be able to specify the line width in the format, which would be cumbersome to parse if RGB/A colors are allowed too.
So:

• keep the aditional 100+ named colors in the format field
• specify line width in the outside color field, ie: "pink:-5[red]" to have a pink dot-dot-dash 5 wide line with blue interior, "magenta-[purple]5" to have a magenta full 5 wide line, "18yellow--[cyan]" etc...
• RGB/A are set in the "EdgeColor" and "FaceColor" fields

[dvinc]

I am not sure having lineWidth setting in the format field keeps things "Matlab simple" (Matlab uses a separate lineWidth property) but why not if you clearly see an advantage. Basically, I think the format field has to remain simple and readable, so don't make it too complicated. People wanting to do more advanced things (like RGBA color selection) are advanced users, so they have to learn how to specify additional properties.