-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📚 New documentation #128
base: dev
Are you sure you want to change the base?
📚 New documentation #128
Conversation
fira7s
commented
Jan 6, 2025
•
edited
Loading
edited
- New documentation
- Fix tutorials page
- Fix dependencies
- Fix docstring placement
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #128 +/- ##
=======================================
Coverage 99.15% 99.15%
=======================================
Files 143 143
Lines 7136 7138 +2
Branches 910 910
=======================================
+ Hits 7076 7078 +2
Misses 27 27
Partials 33 33
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hey, Thank you for the PR. I'll let you handle it, but are you sure that you want to move all class docstrings to the root instead of the |
Hey, i will look more into it and leave relevant doctoring under the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we really need to put caps in the paths?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we do, it might be better to have them in lowercase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we find a solution to avoid script duplication? Maybe through symbolic links, for instance? This may result in a very long GitHub action time, though; we should maybe try something at a lower level to reuse the same pages.
docs/source/_static/cali.png
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe use a more expressive name?
|
||
import tu_sphinx_theme |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove tu_sphink_theme from the deps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't have been pushed in my opinion, since we want to keep all the corruptions in the end