Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug of handle large rpc call response #46

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bryanzhou
Copy link

@bryanzhou bryanzhou commented Oct 25, 2022

If the response of rpc call is separate into serval fragments, will trying to hold them and merge into ONE buffer.

This bug will happen when using this client to download large files.

Here is some log when I download a file with 160MB. It has a large rpc call, and separated into 9 fragments. In old version,
_recordLength is adds up but buffer didn't hold bytes all
image

If the response of rpc call is separate into serval fragments, will trying to hold them and merge into ONE buffer.

This bug will happen when using this client to download large files.
@bryanzhou
Copy link
Author

@twincitiesguy Hello, could you review my code ? I've tested in my project, and it works right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant