Update interrupt priorities so ADC can not get preempted #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esn't get preempted
|
Thanks for sharing, I will try it on my combat robot end of this month lol |
|
I think it can make things worse for PWM and PPM variants, but ideally those variants should use input capture to not be impacted by the interrupt execution timing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After running my vehicles with this change for quite a while now, I am confident in saying that this has fixed an issue that would cause random MOSFET shorts. I suspect that the overcurrent detection interrupt was just a tiny bit too slow because it was preempted. This commit fixes that.