2g downgrade update #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cooperq
requested changes
Jan 17, 2025
cooperq
requested changes
Jan 28, 2025
serial/src/main.rs
Outdated
| // For some reason, on macOS the response buffer gets filled with garbage data that's | ||
| // rarely valid UTF-8. Luckily we only care about the first couple bytes, so just drop | ||
| // the garbage with `from_utf8_lossy` and look for our expected success string. | ||
| let responsestr = String::from_utf8_lossy(&response); |
There was a problem hiding this comment.
This shouldn't be here, we already merged this change into main but it was a different commit hash.
wgreenberg
force-pushed
the
2g-downgrade
branch
from
b82781e to
e24dac1
Compare
cooperq
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on input from Sangwook + this talk: https://www.youtube.com/watch?v=hNDChDM1hEE