Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Sentry #914

Draft
wants to merge 1 commit into
base: 2024-upgrades-main
Choose a base branch
from
Draft

Upgrade Sentry #914

wants to merge 1 commit into from

Conversation

jparr
Copy link
Collaborator

@jparr jparr commented Apr 9, 2024

see: #913

config.dsn = Rails.application.secrets.sentry_dsn
end
Sentry.init do |config|
config.dsn = Rails.application.secrets.sentry_dsn
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to init in order not to error in tests. It won't send events if sentry_dsn is empty.

def set_context
Raven.extra_context(message: request.body.read)
request.body.rewind
end
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This moved to being called inside of the .with_scope block

@alexymik
Copy link
Contributor

alexymik commented Apr 9, 2024

A minor heads up that our internal Sentry instance is Sentry 9.1.2 which doesn't support the new sentry-ruby gem.

@jparr jparr requested a review from esoterik April 10, 2024 17:05
@jparr jparr marked this pull request as draft April 10, 2024 17:07
@jparr
Copy link
Collaborator Author

jparr commented Apr 10, 2024

A minor heads up that our internal Sentry instance is Sentry 9.1.2 which doesn't support the new sentry-ruby gem.

I'll mark this as a draft so it doesnt get merged by accident. @alexymik do you happen to know if upgrading the sentry-raven gem would be compatible? I havent found a compatibility list yet.

@jparr jparr mentioned this pull request Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants