Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed Vega formatting config for performance logging to be compatible with ReFrame 4.X #78

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

casparvl
Copy link
Collaborator

@casparvl casparvl commented Aug 9, 2023

See for an example of the new format: https://reframe-hpc.readthedocs.io/en/stable/configure.html

@casparvl casparvl requested a review from smoors August 9, 2023 12:57
@smoors
Copy link
Collaborator

smoors commented Aug 9, 2023

the alternative is to set 'perflog_compat': True to keep the old behavior, which i had to do in our local test suite for some tests that generate multiple performance values per run. having them all on 1 line breaks our elasticsearch monitoring setup.

but of course we don't know how long that will be supported..

Copy link
Collaborator

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I'll just merge this and leave the actual testing in Vega to you :)

@smoors smoors merged commit 1cffbb4 into EESSI:main Aug 9, 2023
9 checks passed
@boegel boegel added this to the 0.1.0 milestone Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants