Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Description tooltip for experimental effects #784

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

boyestrous
Copy link

@boyestrous boyestrous commented Aug 31, 2024

I thought it would be helpful to have a short description on the tooltip for experimental effects when engineering. Some of the names are self-explanatory, but some of them have additional properties that can't easily be explained with stats (corrosive shell, auto-loader, etc.)

The changes to this file look for a property called "description" in the specials.json file. When none is found, nothing is displayed, so we won't be required to change anything right away.

The corresponding experimental data is stored in the other repository. I figured I would submit this request here to see if you were interested in this change before creating all of the descriptions.

Sample:
"special_armour_thermic": {
"name": "Reflective Plating",
"id": 143,
"description": "Surface coating designed to dissipate thermal energy",
"edname": "special_armour_thermic",
...
}
Example:
Coriolis-Tooltip
Second Example with Text Wrapping:
Coriolis-Tooltip-textwrapping

@boyestrous
Copy link
Author

I apologize, I'm not sure why github is reading this as if I rewrote the entire file. On my computer, it shows only these modified lines...
image

@boyestrous boyestrous marked this pull request as ready for review August 31, 2024 13:53
@alex-williams
Copy link
Collaborator

I really like this idea! I haven't got the time at the moment to properly inspect it, but if you want to go ahead and write the descriptions and ping me when you're done, I'll do my best to integrate it into an upcoming release. Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants