-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add .gitversion file to Linux archive #2118
Conversation
I need to do some additional tests but this is how I'm looking to address #1827 |
This all looks good so far. Let me know when your testing is complete and I'll do my own passes through it :) |
Finished my testing! I undid the renames I mentioned in the PR comment, as I didn't realize renaming GHA workflows changes the link to them. |
@@ -11,7 +11,7 @@ jobs: | |||
variables: | |||
outputs: | |||
sem_ver: ${{ steps.var.outputs.sem_ver }} | |||
archive_exclusions: ${{ steps.var.outputs.archive_exclusions }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't find archive_exclusions
being used anywhere in the rest of the file, so I removed it
Realized from the comment you left on #1827 that the checks should be done in the other order (IE, check for |
Ideally, yes the preference should be the git HEAD, and then the .gitversion file, and then an error out to "unknown". |
@Rixxan Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me! Thanks for contributing this.
Also renames a couple things in the GHA workflow file for building after a release.