[1801] Add Warning for FDevIDs #2111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rixxan
force-pushed
the
enhancement/1801/FDEVID-Check
branch
from
7ef5be9
to
25a4654
Compare
Adds a check to see if the FDevID files exist to the output file generation process. If they don't generate a warning log entry and continue without them.
C1701D
approved these changes
Dec 16, 2023
|
Confirming expected behavior w/ the changes C17 made :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a popup at startup about missing FDevIDs files on startup to EDMC. This popup will come up at every EDMC start, unlike the "Plugin without Python 3.x support" one that only pops up every 24 hours. This includes an option to open the wiki to view the instructions for installing the Git Submodule.
This should only be an issue encountered if running from the source, as the packaged/distributed installs will include this information and files by default. The popup is designed so that it will only pop up once even if both fdevid files are missing or only one is missing.
Type of change
How Has This Been Tested?
find_localised_strings.pydoesn't complain.This is a measure related to #1801 but does not close. Further research should be done for later versions to determine how to avoid the need for this entirely.