-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2051] Config Files Audit #2084
Conversation
Seems something is up with the Linux changes. Time to drill that one down... |
Greetings. I was just wondering why to change type hints for list, dict, type to their deprecated alternatives in typing module? I honestly thought today it's common to migrate from typing.<type> to types itself as they now support subscripting. |
Hey @norohind thanks for pointing that out. I'll be honest, my brain was still operating under the older Python 3.8 typing system. I'll look into the newer typing system and see if we're making an accidental reversion instead of a forwarding of the system. |
As I can't actually get a working Linux instance up right now, rolling back the linux config checks as they are failing the tests. Only going to work on things I can actually test right now. |
I can't adequately test this right now, so not touching it.
Thanks to @norohind for catching this one! I'm not up to date on my PEP585.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good re functionality, some small thing re readability in config/__init__.py
though.
Additionally you're moving back to the deprecated Optional[]
in two files.
And re-adds the missing but deprecated abstracts in config
Broken out of #2068
Description
This is a full-pass update to the core config files, containing a major SemVer-compliant logic overhaul to the files. These updates are intended to optimize existing code, update older Python 2 style code to more updated standards, and increase readability and compatibility.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration