Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cAPI Hanging Auth Issue on EDMC Protocol #2060

Merged
merged 4 commits into from
Aug 8, 2023

Conversation

Rixxan
Copy link
Contributor

@Rixxan Rixxan commented Aug 7, 2023

Description

This Pull fixes an additional issue with the new installer and the EDMC:// protocol. This puts in a more preferred handler key to ensure traffic is redirected appropriately. This is a temporary fix, and the next version (5.10.0) should investigate inverting the preference of the EDMC protocol vs local authentication.

Also changes the name of the default shortcut to be clearer.

Fixes #2057, #2058, #2059, #2062

Full Changes:

  • Adds additional handler key to Windows registry
  • Adds a message box that displays on a successful authentication event.

Type of change

  • Bug Fix

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Multiple install runs, clean installs, self-updates, and others made to confirm functionality, including under a variety of existing pre-install situations.
  • All PyTest tests pass

@Rixxan Rixxan added python Pull requests that update Python code OS Issue CAPI Issues relating to CAPI support Installer Related to the Windows installer labels Aug 7, 2023
@Rixxan Rixxan added this to the 5.10.0 milestone Aug 7, 2023
@Rixxan Rixxan self-assigned this Aug 7, 2023
@Rixxan Rixxan changed the title Fix/2048/capi auth issues Fix cAPI Hanging Auth Issue on EDMC Protocol Aug 7, 2023
@C1701D C1701D merged commit 8a344c8 into EDCD:develop Aug 8, 2023
1 check passed
@C1701D C1701D deleted the fix/2048/capi-auth-issues branch August 8, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CAPI Issues relating to CAPI support Installer Related to the Windows installer OS Issue python Pull requests that update Python code
Projects
None yet
2 participants