-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added View group api #111
Added View group api #111
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Code seems perfect to me 🎉 ! Will test it our locally later.
Perfect usage of get() instead of filter()
and catching the exception. Nice work! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Great job with code quality 🎖️
- The tests are on point. 👏 Really appreciate the use of 12345 for invalid group and org id
{"message":"This organization does not exist"}
and similar responses can be replaced withresponses.org_not_present_404
and equivalents in the view function, as it is static and increases reusability.- in the future error responses use
detail
instead ofmessage
as a key. (as per the discussion on slack 😇 )
3 & 4 are minor things so create good first issue
for both of them
|
Fixes #107
Description
I've added the API, that provides details of a particular group of an organisation to authorised members. It can be visited at
Org.views.GroupDetailsView
. Test Cases and Swagger docs for the same have also been added.Type of Change: (Delete irrelevant options)
Code/Quality Assurance Only (Delete irrelevant options)
How Has This Been Tested?
Tests have been described in
tests.org.tests_view_group_api.py
and they run successfuly. The following is the result of executingpython3 manage.py test
.Checklist:
Code/Quality Assurance