-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Adding Ewald+SPME longrange force solvers #24
base: master
Are you sure you want to change the base?
Conversation
Still WIP. I hope to get the basics laid out, and have everything successfully build before asking for some review. |
Let me know when you want me to look through this in detail. At first glance, you can remove the ExaMiniMD license from the new files you've added, consider a separate folder for longrange_force_types, and make sure using longrange is fully optional. The other thing to consider is deriving the longrange classes from Force, rather than a new base. We could share the neighbor list and energy compute more easily that way |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's what I noticed in a first pass; mainly I'd like to separate the force compute and the comm, potentially the energy and the force. Getting all of this simplified should make the mesh methods much easier
Add example file for NaCl
Creating a new longrange force class, derived from the Force class.
Both Ewald and smooth particle mesh Ewald (SPME) are included - note that the Ewald Sum does not use any FFTs or meshes, only SPME.
Closes #25