-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extended LAMMPS
commands support
#115
base: master
Are you sure you want to change the base?
Conversation
@streeve This is remaining part of our work on CabanaMD. Marking this as a draft, as there are some limitations (mostly being restricted to |
Yes definitely, I will take a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is definitely useful - maybe we make a scripts
or utils
folder?
@@ -328,6 +328,7 @@ void CbnMD<t_System, t_Neighbor>::run() | |||
|
|||
// Exchange atoms across MPI ranks | |||
comm_timer.reset(); | |||
log( std::cout, "Comm::exchange()\tstep ", step ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be unified with the rest of the output?
@@ -268,6 +271,11 @@ void Comm<t_System>::exchange() | |||
|
|||
N_local = N_local + N_total_recv - N_total_send; | |||
|
|||
std::cout << '[' << proc_rank << "] " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here - always better to have more output, but I doubt we always want to output this
} | ||
if ( keyword.compare( "mass" ) == 0 ) | ||
{ | ||
known = true; | ||
int type = std::stoi( words.at( 1 ) ) - 1; | ||
int type = std::stoi( words.at( 1 ) ) - | ||
1; // this is annoying because all other commands have to do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no problem updating this more broadly if it makes things easier
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As someone not very familiar with darma, is it more clear to call this load_balance
or lb
?
Make it possible to define multiple regions (and the size of simulation box will be adjusted accordingly). This is currently rectricted to
fcc
lattice style only.Notable changes:
create_atoms
to fill the region with atoms of specific typemass
to assign mass to atom typevelocity
to assign temperature to atom typeSee
in.darma
deck and the screenshots below for practical demonstration.You can use
paraview --script paraview_process_data.py
to speed up analysis of produced data. It will try to load alldump*
,domain_act*
anddomain_lb*
data files from your current directory and do some basic ParaView visualization.TODO (mostly optional):
group
command supportMultiple regions with different atom types. Note that when the regions overlap, random type will be assigned:
Multiple regions with different velocities:
Types after 100 steps:
Velocities after 100 steps:
Types after 1000 steps: