Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Splines of order 4 - 7 #800

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

rodrigoacb
Copy link

This commits add BSplines of order 4 to 7 following the polynomial definitions on deserno1998 [1]

Following @streeve request, PR #799 is now split into two PRs and once merged, this one will only show diff changes related to Splines.

This changes were done in cooperation with @rhalver

[1] Markus Deserno, Christian Holm; How to mesh up Ewald sums. I. A theoretical and numerical comparison of various particle mesh routines. J. Chem. Phys. 8 November 1998; 109 (18): 7678–7693. https://doi.org/10.1063/1.477414

@streeve streeve requested a review from lebuller November 12, 2024 14:26
@streeve
Copy link
Member

streeve commented Nov 12, 2024

@lebuller can you take a look at the spline updates here? @rodrigoacb probably easiest to rebase out all but the first commit

@rodrigoacb
Copy link
Author

@lebuller can you take a look at the spline updates here? @rodrigoacb probably easiest to rebase out all but the first commit

Thanks @streeve Sam. I rebased onto the first commit and kept the clang-format commit since lt changed files related to this pr

@streeve
Copy link
Member

streeve commented Dec 6, 2024

ping @lebuller

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants