Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: add feature summary #789

Merged
merged 5 commits into from
Oct 9, 2024
Merged

cmake: add feature summary #789

merged 5 commits into from
Oct 9, 2024

Conversation

junghans
Copy link
Member

@junghans junghans commented Oct 7, 2024

Only documented the most important features

@junghans junghans requested a review from streeve October 7, 2024 17:32
CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
Co-authored-by: Damien L-G <[email protected]>
CMakeLists.txt Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
Co-authored-by: Sam Reeve <[email protected]>
@junghans
Copy link
Member Author

junghans commented Oct 8, 2024

@streeve can you add something for HYPRE?

@streeve
Copy link
Member

streeve commented Oct 8, 2024

@streeve can you add something for HYPRE?

Done, I messed up the suggestion..

@junghans
Copy link
Member Author

junghans commented Oct 8, 2024

I only documented the Cabana_ENABLE_GRID option, should we do other?
I think coverage, asm build etc and are not really user facing, so we can ignore that.

@streeve
Copy link
Member

streeve commented Oct 8, 2024

I only documented the Cabana_ENABLE_GRID option, should we do other? I think coverage, asm build etc and are not really user facing, so we can ignore that.

Agreed, and I think all the require options would be too verbose. Added test/example/benchmarks

@junghans
Copy link
Member Author

junghans commented Oct 9, 2024

@dalg24-jenkins re-test this!

@streeve
Copy link
Member

streeve commented Oct 9, 2024

@dalg24-jenkins re-test this!

We still need to get this working again....

@streeve streeve merged commit e1bd563 into master Oct 9, 2024
34 checks passed
@streeve streeve deleted the cmake_summary branch October 9, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants