Fix BovWriter #758
Open
Fix BovWriter #758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
streeve
reviewed
Jun 25, 2024
| array.label(), reorder_space ); | ||
| reorderView( owned_view, owned_subview, reorder_space, ExecutionSpace() ); | ||
|
|
||
| reorderView( owned_view, owned_subview, reorder_space, Kokkos::DefaultHostExecutionSpace{} ); |
There was a problem hiding this comment.
I don't see anything that would stop us from reordering on device, then mirroring after this kernel - what am I missing?
There was a problem hiding this comment.
@abisner I have segment fault error when encounter node_halo->gather and Grid_Halo CUDA test fails as well. Do you have same issue on summit
There was a problem hiding this comment.
@kwitaechong that may be unrelated - this should only affect the grid output tests
streeve
reviewed
Jul 30, 2024
| @@ -267,7 +267,9 @@ void writeTimeStep( ExecutionSpace, const std::string& prefix, | |||
| local_space_max.back() = owned_extents.back(); | |||
| IndexSpace<num_space_dim + 1> local_space( local_space_min, | |||
| local_space_max ); | |||
| auto owned_subview = createSubview( array.view(), local_space ); | |||
|
|
|||
| auto array_host = Kokkos::create_mirror_view_and_copy(Kokkos::HostSpace{}, array.view()); | |||
There was a problem hiding this comment.
Can you try replacing this with a fence instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds missing host mirror copy.
Closes #745.