-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable global particle redistribution based on the grid #707
Conversation
@kwitaechong can you test this as a replacement for your custom |
968f443
to
73245cb
Compare
Currently relying on |
a62ff5e
to
ddb9409
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
retest this please. |
ddb9409
to
06da6f5
Compare
@kwitaechong can you test on Summit or Frontier to find where the device failure is occurring? |
9ba77de
to
d172300
Compare
d172300
to
ce590b0
Compare
Manually checked that tests pass with SYCL. Should be ready to merge once it's removed from Cuda-SYCL tests |
4bc5578
to
23ca966
Compare
I/O timeouts unrelated |
While it should often be avoided, global communication is occasionally needed in applications. This uses the background grid to determine the rank to send any particle to (including removing those outside the global domain).
Still to do:
migrate
functionality to a free function or separate class