Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User-Defined Linear Map #743

Merged

Conversation

cemitch99
Copy link
Member

@cemitch99 cemitch99 commented Oct 15, 2024

This is a duplicate of the draft PR #714 owned by cemitch99. Close #538

Follow-up PR will add

  • return transport matrices in each element
  • push for covariance matrix
    • add: ImpactX::track_envelope

@cemitch99 cemitch99 changed the title Topic covariance and transport maps Transport and Covariance Matrices Oct 15, 2024
Correct naming in elements.cpp binding for LinearMap.
{
}

//LinearTransport () = default;

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After thinking a bit more about this for the follow-up PR: we want to probably create a function that returns R for each element, but we do not want to store R as a member variable -- at least not with the same class we use for pushing. Can explain in more detail after this PR, but it's mainly about the size of the class we copy to GPU for tracking purposes not not to bloat that.

cemitch99 and others added 4 commits October 23, 2024 15:15
Correct argument declaration for Python bindings of LinearMap in elements.cpp.
Document "Name" parameter in LinearMap.
@ax3l ax3l self-requested a review January 6, 2025 04:48
@ax3l ax3l self-assigned this Jan 6, 2025
Correct name of Rmat/R.
Fix naming of R again.
Fix number of periods.
Copy link
Member

@ax3l ax3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a very cool example, thank you!

examples/linear_map/README.rst Outdated Show resolved Hide resolved
examples/linear_map/README.rst Outdated Show resolved Hide resolved
examples/linear_map/README.rst Outdated Show resolved Hide resolved
examples/linear_map/input_map.in Show resolved Hide resolved
docs/source/usage/python.rst Outdated Show resolved Hide resolved
examples/CMakeLists.txt Outdated Show resolved Hide resolved
docs/source/usage/python.rst Outdated Show resolved Hide resolved
ax3l added 2 commits January 12, 2025 22:50
Taken over from generalized version we merged to WarpX.
src/python/elements.cpp Outdated Show resolved Hide resolved
examples/CMakeLists.txt Outdated Show resolved Hide resolved
Copy link
Member

@ax3l ax3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks great to me :)

src/python/elements.cpp Outdated Show resolved Hide resolved
@ax3l ax3l merged commit 5638dfd into ECP-WarpX:development Jan 13, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: elements Elements/external fields
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User-Defined Linear Map
2 participants