-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User-Defined Linear Map #743
User-Defined Linear Map #743
Conversation
General structure. Co-authored-by: Chad Mitchell <[email protected]>
Update initialization of LinearMap element.
for more information, see https://pre-commit.ci
Finish implementation of LinearMap element push.
for more information, see https://pre-commit.ci
Initialize covariance matrix from distribution parameters.
for more information, see https://pre-commit.ci
…ance-and-transport-maps
Remove unnecessary ,.
Correct naming in elements.cpp binding for LinearMap.
{ | ||
} | ||
|
||
//LinearTransport () = default; |
Check notice
Code scanning / CodeQL
Commented-out code Note
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After thinking a bit more about this for the follow-up PR: we want to probably create a function that returns R for each element, but we do not want to store R as a member variable -- at least not with the same class we use for pushing. Can explain in more detail after this PR, but it's mainly about the size of the class we copy to GPU for tracking purposes not not to bloat that.
Correct argument declaration for Python bindings of LinearMap in elements.cpp.
Document "Name" parameter in LinearMap.
Modify zero-initialization of CovarianceMatrix cv.
Correct name of Rmat/R.
Fix naming of R again.
Fix number of periods.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a very cool example, thank you!
Co-authored-by: Chad Mitchell <[email protected]>
for more information, see https://pre-commit.ci
Taken over from generalized version we merged to WarpX.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks great to me :)
This is a duplicate of the draft PR #714 owned by cemitch99. Close #538
amrex::SmallMatrix
ImpactX::evolve
->ImpactX::track_particles
Introducesim.track_particles()
#741Follow-up PR will add
ImpactX::track_envelope