[Dashboard] Improved Simulation Output Logging #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improvement from current, however it would be ideal that the contents stream out on the terminal view as the simulation runs, not just at once when the simulation is completed. Using wurlitzer library for this
|
Thanks! I think we can alternatively solve this in pyAMReX modifying AMReX' |
ax3l
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR improves existing simulation logging by displaying simulation diagnostics in the Trame xterm.
Note: The output is currently streamed to the Trame xterm only after the simulation has completed. The ideal behavior, where the contents are streamed progressively as the simulation runs, is still a work in progress.
Wurlitzer library utilized for this functionality.
Before
After