Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix main() Profile Region #711

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Fix main() Profile Region #711

merged 2 commits into from
Sep 23, 2024

Conversation

AlexanderSinn
Copy link
Member

@AlexanderSinn AlexanderSinn commented Sep 23, 2024 •
edited by ax3l
Loading

Address new errors with AMReX development of the kind:

189: 0::Assertion `m_profiler.m_do_profiling == false' failed, file "Src/Base/AMReX_Arena.cpp", line 123 !!!

and

5: terminate called after throwing an instance of 'std::runtime_error'
5:   what():  Assertion `static_cast<int>(ttstack.size()) == global_depth' failed, file "Src/Base/AMReX_TinyProfiler.cpp", line 174, Msg: "TinyProfiler sections must be nested with respect to each other"

WeiqunZhang
WeiqunZhang reviewed Sep 23, 2024
View reviewed changes
src/main.cpp Outdated Show resolved Hide resolved
ax3l
ax3l reviewed Sep 23, 2024
View reviewed changes
src/main.cpp Outdated Show resolved Hide resolved
ax3l
ax3l reviewed Sep 23, 2024
View reviewed changes
src/ImpactX.cpp Outdated Show resolved Hide resolved
ax3l
ax3l reviewed Sep 23, 2024
View reviewed changes
src/main.cpp Show resolved Hide resolved
@ax3l ax3l mentioned this pull request Sep 23, 2024
Merged
5 tasks
ax3l
ax3l reviewed Sep 23, 2024
View reviewed changes
src/main.cpp Show resolved Hide resolved
ax3l
ax3l approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@ax3l ax3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Alex! ✨

@ax3l ax3l enabled auto-merge (squash) September 23, 2024 20:51
@AlexanderSinn AlexanderSinn changed the title [Test] Fix amrex::Finalize [Test] Fix main() Profile Region Sep 23, 2024
@AlexanderSinn AlexanderSinn changed the title [Test] Fix main() Profile Region Fix main() Profile Region Sep 23, 2024
@ax3l ax3l merged commit f8a033f into ECP-WarpX:development Sep 23, 2024
16 checks passed
WeiqunZhang pushed a commit to AMReX-Codes/amrex that referenced this pull request Sep 23, 2024
@AlexanderSinn
Deregister BArena from Profiling in Arena::Finalize (#4164)
35353fb 
## Summary

Since the BArena is not destructed in Arena::Finalize, we need to
manually deregister it from memory profiling to avoid an assert when
initializing the next time.

## Additional background

ECP-WarpX/impactx#711
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WeiqunZhang WeiqunZhang WeiqunZhang left review comments

@ax3l ax3l ax3l approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexanderSinn @ax3l @WeiqunZhang