Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove distutils #451

Merged

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Oct 27, 2023

@ax3l ax3l added install component: python Python bindings labels Oct 27, 2023
@ax3l ax3l force-pushed the install-setuptools-py3.12-nodistutils branch 3 times, most recently from adf0f51 to 949e245 Compare October 27, 2023 17:41
README.md Outdated
@@ -30,189 +30,7 @@ Our workflow is described in [CONTRIBUTING.rst](CONTRIBUTING.rst).

## Developer Environment

Please prepare you local development environment as follows.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine here, but would be cleaner if this change was done in a separate PR since it isn't related to the main topic.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, sorry that was a it sloppy and makes this harder to Backport/patch where needed indeed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved this to #453

@dpgrote
Copy link
Member

dpgrote commented Oct 27, 2023

This looks good and I can approve, though I have one comment posted.

Would there be a way to put all of the "python -m pip install" commands in a script so that they don't need to be written out in each of the 10 files as is now?

@ax3l
Copy link
Member Author

ax3l commented Oct 29, 2023

Yes, technically this is all in pyproject.yaml, let me see how to install that in a two liner or so.

Pip has to definitely be upgraded first and solely, because some people start with ancient pip installs that would not understand later pip steps we do.

Update: since we do not build with --no-build-isolation, technically all we would need is the latest pip... Will revisit that part another time, I have not problem updating this with git grep where listed. Avoids that one has to have the source cloned at that step.

Distutils is gone in Python 3.12+.
@ax3l ax3l force-pushed the install-setuptools-py3.12-nodistutils branch from 949e245 to c9626f3 Compare October 29, 2023 22:11
@ax3l ax3l merged commit e388682 into ECP-WarpX:development Oct 31, 2023
15 checks passed
@ax3l ax3l deleted the install-setuptools-py3.12-nodistutils branch October 31, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants