CMake: lib w/ other name than app/exe on Win

ECP-WarpX · Jul 31, 2023 · 9647628 · 9647628
1 parent 740da03
commit 9647628
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -200,7 +200,7 @@ if(ImpactX_PYTHON)
     else()
         pybind11_extension(pyImpactX)
     endif()
-    if(NOT MSVC AND NOT ${CMAKE_BUILD_TYPE} MATCHES Debug|RelWithDebInfo)
+    if(NOT MSVC AND NOT ${CMAKE_BUILD_TYPE} MATCHES Debug|RelWithDebInfo)  # change to NOT WIN32 AND NOT ... ?
         pybind11_strip(pyImpactX)
     endif()
 endif()

diff --git a/cmake/ImpactXFunctions.cmake b/cmake/ImpactXFunctions.cmake
@@ -248,9 +248,13 @@ function(impactx_set_binary_name)
     if(ImpactX_APP)
         list(APPEND ImpactX_bin_names app)
     endif()
+    if(WIN32)
+        set_target_properties(lib PROPERTIES OUTPUT_NAME "libimpactx")
+    else()
+        set_target_properties(lib PROPERTIES OUTPUT_NAME "impactx")
+    endif()
+    set_target_properties(app PROPERTIES OUTPUT_NAME "impactx")
     foreach(tgt IN LISTS ImpactX_bin_names)
-        set_target_properties(${tgt} PROPERTIES OUTPUT_NAME "impactx")
-
         if(ImpactX_MPI)
             set_property(TARGET ${tgt} APPEND_STRING PROPERTY OUTPUT_NAME ".MPI")
         else()