Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implicit Field Solve Preconditioner based on Curl-Curl Operator #5286
Implicit Field Solve Preconditioner based on Curl-Curl Operator #5286
Changes from 10 commits
ef110d5
8196a85
248e21e
40d11ab
6cbebe6
0f3218a
daa8edc
ea3838b
482bc73
aff9965
5c45dc1
4801d6c
75b88f9
d2d7ea6
e601e91
79aa72c
0db699d
e9ff4f2
ff0d8d3
a698210
ac479fc
af56e98
cabcf74
d1bb01b
4228075
4a3c2ba
70c5f3f
4fe3cfb
0c4c1d7
42cc9ec
98b0363
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Making this a member of the base class is fine for now. In a future PR, we can remove it by passing in m_theta*a_dt to the solver. This will require modifications to several files in the ImplicitSolver folder and in the NonlinearSolvers folder, but it will make the code more tidy. I can do this after this PR is merged.