Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Time-Averaged Field Diagnostics #5285

Merged
merged 26 commits into from
Oct 24, 2024

Commits on Oct 18, 2024

  1. skeleton sprinkled around

    RevathiJambunathan authored and n01r committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    8dbde7d View commit details
    Browse the repository at this point in the history
  2. Add time step interval logic

    n01r committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    2707593 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a1b21d2 View commit details
    Browse the repository at this point in the history
  4. Add summation of MultiFabs

    n01r committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    0aee250 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    1fef795 View commit details
    Browse the repository at this point in the history
  6. Continue averaging period logic

    - Implement warnings and errors for certain inputs concerning averaging periods
    n01r committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    17d7620 View commit details
    Browse the repository at this point in the history
  7. Add docs and scope code in if envs

    - added first documentation on time averaged diags
    - put more operations on summation multifabs into if-environments
    n01r committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    c4b1775 View commit details
    Browse the repository at this point in the history
  8. Implement clang-tidy fixes

    n01r committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    d4cb9ae View commit details
    Browse the repository at this point in the history
  9. Add time averaged diags to laser ion example

    - added time averaged diags to laser-ion acceleration example
    - fix first issues that came up when testing this
    n01r committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    ac216cc View commit details
    Browse the repository at this point in the history
  10. Add more warnings and user info

    n01r committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    66adf7f View commit details
    Browse the repository at this point in the history
  11. Add PICMI functionality

    n01r committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    1bb3c7b View commit details
    Browse the repository at this point in the history
  12. [pre-commit.ci] auto fixes from pre-commit.com hooks

    for more information, see https://pre-commit.ci
    pre-commit-ci[bot] authored and n01r committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    c5f2e73 View commit details
    Browse the repository at this point in the history
  13. Add and fix docs

    n01r committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    07e9b0e View commit details
    Browse the repository at this point in the history
  14. Add abort for adaptive time-stepping

    Currently, we do not yet support the newly implemented adaptive time-stepping
    mode of electrostatic solvers together with time-averaged diagnostics.
    n01r committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    ea09ac2 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    98065f4 View commit details
    Browse the repository at this point in the history
  16. Added automated test based on LPI example

    Even though the laser ion test is named as a dependency it is running this
    test again. That should ideally be avoided. It would be good to just run
    the analysis script as test.
    n01r committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    171ce3c View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    13cd6e4 View commit details
    Browse the repository at this point in the history
  18. Unify CI test for regression and TimeAvgDiag

    For PICMI, the TimeAveragedDiag test is automatically disabled because we
    cannot simply define the necessary output intervals.
    We need to be able to define period=[100,69:100] like for the app input.
    n01r committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    22bc9a9 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    0a46605 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. Apply suggestions from code review

    Modify checksum evaluation call to follow example from PR ECP-WarpX#5297.
    
    Co-authored-by: Edoardo Zoni <[email protected]>
    n01r and EZoni authored Oct 21, 2024
    Configuration menu
    Copy the full SHA
    7c629d8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8a26f22 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. Configuration menu
    Copy the full SHA
    83ae4b9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6ac6212 View commit details
    Browse the repository at this point in the history
  3. Apply suggestions from code review

    Co-authored-by: Edoardo Zoni <[email protected]>
    n01r and EZoni authored Oct 22, 2024
    Configuration menu
    Copy the full SHA
    8b10e46 View commit details
    Browse the repository at this point in the history
  4. Update comment in Diagnostics.cpp

    Co-authored-by: Edoardo Zoni <[email protected]>
    n01r and EZoni authored Oct 22, 2024
    Configuration menu
    Copy the full SHA
    b9fc39e View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. Update relative tolerance to stricter value

    Updating the relative tolerance to 1e-12 to keep it strict because the test compares two diagnostics that come from the same run on the same machine, just that one averaging happens in-situ while the other is done in post-processing.
    
    Co-authored-by: Edoardo Zoni <[email protected]>
    n01r and EZoni authored Oct 24, 2024
    Configuration menu
    Copy the full SHA
    fa03561 View commit details
    Browse the repository at this point in the history