Add external particle fields ohms law hybrid #5275
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: S. Eric Clark <[email protected]>
Adding time value for particle field lookup in field substepping.
clarkse
force-pushed
the
add_external_particle_fields_ohms_law_hybrid
branch
from
b534e43
to
5f75428
Compare
for more information, see https://pre-commit.ci
Signed-off-by: S. Eric Clark <[email protected]>
….com:clarkse/WarpX into add_external_particle_fields_ohms_law_hybrid
… Cylindrical and Cartesian.
for more information, see https://pre-commit.ci
Signed-off-by: S. Eric Clark <[email protected]>
….com:clarkse/WarpX into add_external_particle_fields_ohms_law_hybrid
for more information, see https://pre-commit.ci
Signed-off-by: S. Eric Clark <[email protected]>
….com:clarkse/WarpX into add_external_particle_fields_ohms_law_hybrid
…tical field values into ghost cells. The E/B fields and edge_lengths have different numbers of ghost cells. Signed-off-by: S. Eric Clark <[email protected]>
…hen not enabled. Signed-off-by: S. Eric Clark <[email protected]>
…ternal data loading. Signed-off-by: S. Eric Clark <[email protected]>
… computed by curlA and E is computed by computing numerical derivative of seperable time component.
….com:clarkse/WarpX into add_external_particle_fields_ohms_law_hybrid
….com:clarkse/WarpX into add_external_particle_fields_ohms_law_hybrid
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Source/FieldSolver/FiniteDifferenceSolver/HybridPICModel/ExternalVectorPotential.cpp
Fixed
Show fixed
Hide fixed
Signed-off-by: S. Eric Clark <[email protected]>
Signed-off-by: S. Eric Clark <[email protected]>
Signed-off-by: S. Eric Clark <[email protected]>
Signed-off-by: S. Eric Clark <[email protected]>
Signed-off-by: S. Eric Clark <[email protected]>
Signed-off-by: S. Eric Clark <[email protected]>
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Thanks for this PR!
I like the approach in that it mostly keeps the augmented functionality separate from the Ohm's law solving.
One thing though, this really includes 2 PRs in one
- Introduction of the EB "Covered" functionality
- The external fields in the hybrid algorithm
Do you think it would be feasible to pull the "covered" stuff into a separate PR? That would help a lot in reviewing and merging.
Comment on lines
364
to
365
| auto& warpx = WarpX::GetInstance(); | ||
| warpx.ApplyEfieldBoundary(lev, PatchType::fine); |
There was a problem hiding this comment.
Why is it necessary to move this here?
There was a problem hiding this comment.
I was looking around to fix some boundary issues. I will double check on this.
… not using. Signed-off-by: S. Eric Clark <[email protected]>
Signed-off-by: S. Eric Clark <[email protected]>
for more information, see https://pre-commit.ci
Co-authored-by: Roelof Groenewald <[email protected]>
Co-authored-by: Roelof Groenewald <[email protected]>
Co-authored-by: Roelof Groenewald <[email protected]>
Co-authored-by: Roelof Groenewald <[email protected]>
Co-authored-by: Roelof Groenewald <[email protected]>
Co-authored-by: Roelof Groenewald <[email protected]>
Co-authored-by: Roelof Groenewald <[email protected]>
Signed-off-by: S. Eric Clark <[email protected]>
….com:clarkse/WarpX into add_external_particle_fields_ohms_law_hybrid
Comment on lines
+364
to
+365
| // auto& warpx = WarpX::GetInstance(); | ||
| // warpx.ApplyEfieldBoundary(lev, PatchType::fine); |
Check notice
Code scanning / CodeQL
Commented-out code Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows for the addition of external fields through the particle fields analytical interface. This is useful for field splitting external vs. self fields in the hybrid ohm's law solver.