Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EB: Cleanup & Simplify #5223

Merged
merged 4 commits into from
Sep 10, 2024
Merged

EB: Cleanup & Simplify #5223

merged 4 commits into from
Sep 10, 2024

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Sep 6, 2024

Cleaning & clarity follow-up to #4865:

  • inline review comments by @RemiLehe
  • inline review comment by @EZoni
  • WarpX class: remove double book-keeping from m_eb_enabled

ax3l and others added 2 commits September 6, 2024 14:44
Co-authored-by: Remi Lehe <[email protected]>
Remove double book-keeping.
@ax3l ax3l added cleaning Clean code, improve readability component: boundary PML, embedded boundaries, et al. labels Sep 6, 2024
@ax3l ax3l requested review from RemiLehe and EZoni September 6, 2024 21:57
@RemiLehe RemiLehe enabled auto-merge (squash) September 10, 2024 02:53
@RemiLehe RemiLehe merged commit 7f33c8f into ECP-WarpX:development Sep 10, 2024
37 checks passed
@ax3l ax3l deleted the cleanup-eb branch September 10, 2024 07:56
@ax3l
Copy link
Member Author

ax3l commented Sep 10, 2024

Thx for the fixes :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleaning Clean code, improve readability component: boundary PML, embedded boundaries, et al.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants