Reduce particle shape when a particle approaches the EB #5209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lgorithms with PML BC
This reverts commit 0051a17.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
RemiLehe
changed the title
for more information, see https://pre-commit.ci
…//github.com/oshapoval/WarpX into add_analysis_embedded_boundary_removal_depth
oshapoval
changed the title
oshapoval
force-pushed
the
add_analysis_embedded_boundary_removal_depth
branch
from
f2ec5f7
to
ae888f1
Compare
…mbedded_boundary_removal_depth
…or=1,2,3 in 2D,3D and RZ
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…e if (EB::enabled()) condition
oshapoval
force-pushed
the
add_analysis_embedded_boundary_removal_depth
branch
from
811b9e0
to
66b029e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another attempt at fixing the issue mentioned in #4816 (i.e. avoid spurious charge build-up at the embedded boundary, when particles are removed).
In this PR, the shape of the particle is reduced to order 1 when the particle is close enough to the EB, when using the Esirkepov deposition.