Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DSMC reaction weight calculation #5135

Merged
merged 5 commits into from
Aug 19, 2024

Conversation

roelof-groenewald
Copy link
Member

@roelof-groenewald roelof-groenewald commented Aug 14, 2024

This PR updates the DSMC scheme to use the updated reaction weight calculation described by @JustinRayAngus in #5047.

Still to do:

  • rerun benchmark calculations to confirm implementation accuracy
  • reset checksum values
  • add input parameter that sets minimum weight ratio for which particles will be split and recombine particles from the higher weight particle if that value is not exceeded (do this in DSMC: add minimum reaction weight for particle splitting #4976 after this PR is merged)

@roelof-groenewald roelof-groenewald added the component: collisions Anything related to particle collisions label Aug 14, 2024
@roelof-groenewald roelof-groenewald changed the title Update DSMC reaction weight calculation [WIP] Update DSMC reaction weight calculation Aug 14, 2024
@roelof-groenewald roelof-groenewald marked this pull request as ready for review August 14, 2024 05:26
@roelof-groenewald
Copy link
Member Author

roelof-groenewald commented Aug 18, 2024

I reran the physics benchmark used to originally validate the DSMC implementation (comparing against the Turner 2013 MCC benchmark). The plots below show the results for the 1st case using different numbers of kinetic neutral particles:
image

The results match expectation unless the number of neutral particles is too low (neutral density is much higher than plasma density in this problem so good statistics would require more neutral macro-particles than for ions).

@roelof-groenewald roelof-groenewald changed the title [WIP] Update DSMC reaction weight calculation Update DSMC reaction weight calculation Aug 18, 2024
@roelof-groenewald
Copy link
Member Author

Here are the results of running the benchmark simulations for cases 2 & 3 as well. The results match expectation in all cases.
image

Copy link
Contributor

@JustinRayAngus JustinRayAngus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me.

@ax3l ax3l merged commit f02aaa2 into ECP-WarpX:development Aug 19, 2024
47 checks passed
@roelof-groenewald roelof-groenewald deleted the dsmc_pairing_update branch August 19, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: collisions Anything related to particle collisions enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants