Docs: Thomson Parabola Spectrometer example #5058
Conversation
for more information, see https://pre-commit.ci
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Examples/Physics_applications/thomson_parabola_spectrometer/plot_detector.py
Fixed
Show fixed
Hide fixed
Examples/Physics_applications/thomson_parabola_spectrometer/plot_detector.py
Fixed
Show fixed
Hide fixed
Examples/Physics_applications/thomson_parabola_spectrometer/plot_detector.py
Fixed
Show fixed
Hide fixed
There was a problem hiding this comment.
Hi @aeriforme ! Thanks a lot for this PR! I've left a couple of comments.
In addition we should consider (and I don't have an immediate answer):
- where should we store the figures (our current policy forbids files that are not inputfiles, scripts or README in the example folder)
- if this example should also become a CI test
Examples/Physics_applications/thomson_parabola_spectrometer/plot_detector.py
Outdated
Show resolved
Hide resolved
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Thanks a lot for this new example, @aeriforme .
I left very few comments, but I think that this PR could be merged very soon.
| # some parameters from the inputfile | ||
| Emax_hydrogen1_1 = 40*MeV | ||
| Emax_carbon12_6 = 20*MeV | ||
| Emax_carbon12_5 = 20*MeV |
There was a problem hiding this comment.
| Emax_carbon12_5 = 20*MeV | |
| Emax_carbon12_4 = 20*MeV |
Shouldn't this be Emax_carbon12_4 ?
There was a problem hiding this comment.
But in any case it seems that these variables are unused. Maybe you can comment them or delete them
| diag1.diag_type = Full | ||
| diag1.fields_to_plot = Ex Bx | ||
| diag1.format = openpmd | ||
| diag1.intervals = 100 | ||
| diag1.openpmd_backend = bp | ||
| diag1.write_species = 1 | ||
| diag1.species = hydrogen1_1 carbon12_6 carbon12_4 | ||
| diag1.dump_last_timestep = 1 |
There was a problem hiding this comment.
diag1 plots the simulation results also at timestep 0, which is what diag0 does. Is this the intended behavior?
Co-authored-by: Luca Fedeli <[email protected]>
There was a problem hiding this comment.
Hi @aeriforme ! I have only one tiny comment. Besides of this comment, the PR looks very good.
| diag1.diag_type = Full | ||
| diag1.fields_to_plot = Ex Bx | ||
| diag1.format = openpmd | ||
| diag1.intervals = 0 |
There was a problem hiding this comment.
Do you mean at time zero (0:0 could be more readable, I think) or "at every timestep" (in which case I would suggest 1)?
for more information, see https://pre-commit.ci
|
@aeriforme , could you please fix the merge conflicts? |
This PR adds a new example where different ion species travel through a Thomson Parabola Spectrometer and are collected at a screen.
The example can be found in the
PhysicsApplications/thomson_parabola_spectrometerfolder.