Enable general weight scaling for radial particle distributions #5009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
This reverts commit 521dc5d.
Trying to fix the error during the test:
/home/runner/work/WarpX/WarpX/Source/Initialization/PlasmaInjector.cpp:72:5: warning: 'zmax' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer]
zmax = std::numeric_limits<amrex::Real>::max();
for more information, see https://pre-commit.ci
Adding "amrex::Real" to define xmin,ymin,zmin,xmax,ymax,zmax
dpgrote
added
geometry: RZ
dpgrote
commented
Jul 12, 2024
| @@ -142,6 +142,7 @@ def calculate_error(E_axis, xmin, dx, nx): | |||
| print("L2 error along x-axis = %s" %L2_error_x) | |||
| print("L2 error along y-axis = %s" %L2_error_y) | |||
| print("L2 error along z-axis = %s" %L2_error_z) | |||
| print("L2 error tolerance = %s" %l2_tolerance) | |||
There was a problem hiding this comment.
These print statements were added to provide more output in cases when the checks fail. This was helpful in getting the new CI test working.
dpgrote
commented
Jul 12, 2024
| electron.charge = -q_e | ||
| electron.mass = m_e | ||
| electron.injection_style = "NUniformPerCell" | ||
| electron.num_particles_per_cell_each_dim = 6 2 2 |
There was a problem hiding this comment.
Note here that more particles are needed in this test compared to the non-uniformly weighted case to get to the same tolerance. This is because the error is being checked on axis which has fewer particles when doing uniform weighting.
dpgrote
commented
Jul 12, 2024
| @@ -51,7 +51,7 @@ | |||
| ########################## | |||
|
|
|||
| uniform_plasma = picmi.UniformDistribution(density = density, | |||
| upper_bound = [+18e-6, +18e-6, None], | |||
| upper_bound = [+18e-6, None, +40e-6], | |||
There was a problem hiding this comment.
This was a bug found in this input file that made this test fail with the updated code.
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the new input parameter
radial_weight_powerwhich specifies the radial power for the particle weight when using cylindrical geometry. The default value of 1 gives uniform particles per cells with increasing weight with radius, the value 0 gives uniformly weighted particles.Note that this removes the parameter
radially_weightedwhich is no longer used and could not be changed from its default value anyway.Several CI benchmarks are updated due to changes in round-off.
Note that this replaces PR #4342