-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
warpx.roundrobin_sfc: A runtime parameter to control distribution mapping #4909
Conversation
99d9517
to
6f15ec5
Compare
…ping The default is false. If it's true, AMReX's RRSFS strategy will be used to override the default SFC strategy used by amrex::AmrCore. The motivation for this is that this might mitigate the load imbalance issue during initialization by avoiding putting neighboring boxes on the same process.
6f15ec5
to
275f45a
Compare
Looks good. Would his affect the runtime, slowing the MPI communication since neighboring boxes will be far away from each other? |
@WeiqunZhang sorry for the delay, can you please rebase? |
Thank you, @WeiqunZhang! |
c75adf3
to
4babfd5
Compare
Thank you so much! After checking back with our collaborators, we currently do not have a reproducer at hand, but I'll include it in the coming release so we can try it when we should find one again. @n01r might have one we can try this on, too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @WeiqunZhang! ✨
The idea is to overcome out-of-memory in the init routines (e.g., for LPI sims with a lot of particles in close-by ranks) and then apply load balancing based on a user-defined cost (and distribution) model, as usual. |
The default is false. If it's true, AMReX's RRSFC strategy will be used to override the default SFC strategy used by amrex::AmrCore. The motivation for this is that this might mitigate the load imbalance issue during initialization by avoiding putting neighboring boxes on the same process.