-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 3.12: Refactor out Distutils #4392
Merged
ax3l
merged 8 commits into
ECP-WarpX:development
from
ax3l:install-setuptools-py3.12-nodistutils
Nov 3, 2023
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
8d4b0fb
CI: Unconstrain Some Upper Py Versions
ax3l bcaacf0
Replace distutils
ax3l 1d6e5e2
Update Docs
ax3l 5cfeb2e
no `clean` commmand
ax3l 11944ec
Remove `SETUPTOOLS_USE_DISTUTILS`
ax3l f4a9418
Update Doc String
ax3l 03fe4f6
Update CI
ax3l 01546e7
Update Tools/machines/lassen-llnl/install_v100_ml.sh
ax3l File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,16 +18,12 @@ jobs: | |
env: | ||
CXXFLAGS: "-Werror" | ||
CMAKE_GENERATOR: Ninja | ||
# setuptools/mp4py work-around, see | ||
# https://github.com/mpi4py/mpi4py/pull/159 | ||
# https://github.com/mpi4py/mpi4py/issues/157#issuecomment-1001022274 | ||
SETUPTOOLS_USE_DISTUTILS: stdlib | ||
steps: | ||
- uses: actions/checkout@v3 | ||
- uses: actions/setup-python@v4 | ||
name: Install Python | ||
with: | ||
python-version: '3.10' | ||
python-version: '3.x' | ||
- name: install dependencies | ||
run: | | ||
.github/workflows/dependencies/nvcc11-3.sh | ||
|
@@ -75,7 +71,8 @@ jobs: | |
-DAMReX_CUDA_ERROR_CAPTURE_THIS=ON | ||
cmake --build build_sp -j 2 | ||
|
||
python3 -m pip install --upgrade pip setuptools wheel | ||
python3 -m pip install --upgrade pip | ||
python3 -m pip install --upgrade build packaging setuptools wheel | ||
export WARPX_MPI=ON | ||
export PYWARPX_LIB_DIR=$PWD/build_sp/lib/site-packages/pywarpx/ | ||
python3 -m pip wheel . | ||
|
@@ -118,13 +115,9 @@ jobs: | |
name: [email protected] NVCC/NVC++ Release [tests] | ||
runs-on: ubuntu-20.04 | ||
if: github.event.pull_request.draft == false | ||
env: | ||
# For NVHPC, Ninja is slower than the default: | ||
#CMAKE_GENERATOR: Ninja | ||
# setuptools/mp4py work-around, see | ||
# https://github.com/mpi4py/mpi4py/pull/159 | ||
# https://github.com/mpi4py/mpi4py/issues/157#issuecomment-1001022274 | ||
SETUPTOOLS_USE_DISTUTILS: stdlib | ||
#env: | ||
# # For NVHPC, Ninja is slower than the default: | ||
# CMAKE_GENERATOR: Ninja | ||
steps: | ||
- uses: actions/checkout@v3 | ||
- name: Dependencies | ||
|
@@ -175,7 +168,8 @@ jobs: | |
# https://github.com/mpi4py/mpi4py/issues/114 | ||
#export CFLAGS="-noswitcherror" | ||
|
||
#python3 -m pip install --upgrade pip setuptools wheel | ||
#python3 -m pip install --upgrade pip | ||
#python3 -m pip install --upgrade build packaging setuptools wheel | ||
#export WARPX_MPI=ON | ||
#export PYWARPX_LIB_DIR=$PWD/build/lib/site-packages/pywarpx/ | ||
#python3 -m pip wheel . | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unconstrain the upper Python version that gets installed. I constrained it in ed13486 to unbreak CI by avoiding Python 3.12 for a few days.
I want it unconstrained again, so I see if there are breaking changes once new Python versions are released.
Ref.: https://github.com/actions/setup-python#setup-python